[8.17] Backport of #190, dynamic CI pr/build/e2e jobs for target branch. #201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ic#190) * Sync up with ES main that PipelineConfiguration class getConfigAsMap() method renamed to getConfig(). * Request modifiable donfig when creating a pipeline.
donoghuc
previously requested changes
Dec 9, 2024
There was a problem hiding this comment.
I dont think this refactor is going into 8 series of elasticsearch? https://github.com/elastic/elasticsearch/pull/117038/files#diff-8453c77b7623b8913c31d5299ce86fce8b850e0414d64b317ee8e80e62f1cd29
mashhurs
commented
Dec 10, 2024
gradle.properties
Outdated
| @@ -1,2 +1,2 @@ | |||
| LOGSTASH_PATH=../../logstash | |||
| ELASTICSEARCH_TREEISH=8.16 | |||
| ELASTICSEARCH_TREEISH=8.x | |||
There was a problem hiding this comment.
Suggested change
| ELASTICSEARCH_TREEISH=8.x | |
| ELASTICSEARCH_TREEISH=8.17 |
mashhurs
commented
Dec 10, 2024
| @@ -1,15 +1 @@ | |||
| if [ -z "$ELASTICSEARCH_TREEISH" ]; then | |||
There was a problem hiding this comment.
We don't need to touch es-treeish as we utilize from gradle.properties, similarly no need to set target branch env var as this script target branches itself.
mashhurs
force-pushed
the
sync-with-es-on-8x
branch
from
f3f1ca5 to
6261c6a
Compare
mashhurs
changed the title
PipelineConfiguration class changes. (#190)
donoghuc
dismissed
their stale review
I was looking at the wrong branch in ES
- print target branch for debugging purpose - add return type `None` to void method. Co-authored-by: Cas Donoghue <[email protected]>
💔 Build Failed
Failed CI StepsHistory
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #190 into 8.17
Cherry pick details
Sync up with ES main that PipelineConfiguration class getConfigAsMap() method renamed to getConfig().
Request modifiable donfig when creating a pipeline.
Thanks for contributing to Logstash! If you haven't already signed our CLA, here's a handy link: https://www.elastic.co/contributor-agreement/