Rename GH secret. #217
Merged
Rename GH secret. #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
|
yaauie
approved these changes
Jan 8, 2025
donoghuc
reviewed
Jan 8, 2025
| organization: elastic | ||
| team: logstash | ||
| GITHUB_TOKEN: ${{ secrets.READ_ORG_SECRET_JSVD }} | ||
| GITHUB_TOKEN: ${{ secrets.READ_ORG_SECRET_MASHHURS }} |
There was a problem hiding this comment.
Suggested change
| GITHUB_TOKEN: ${{ secrets.READ_ORG_SECRET_MASHHURS }} | |
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
I dont understand why we need to tie this to someone's personal token. Why cant we use the one provided by GHA? https://docs.github.com/en/[email protected]/actions/security-for-github-actions/security-guides/automatic-token-authentication#permissions-for-the-github_token
There was a problem hiding this comment.
Another bump for "why dont we use an off the shelf solution" #203 (review)
There was a problem hiding this comment.
Oh, i see the default one applies only to the repo, not the org.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Logstash! If you haven't already signed our CLA, here's a handy link: https://www.elastic.co/contributor-agreement/