Skip to content

Conversation

github-actions[bot]
Copy link
Contributor

Backport PR #247 to 8.x branch, original message:


Description

Plugin aligns with stack {major.minor} now. This gives an opportunity to highlight in the logs if plugin is running against the different ES version from the version plugin is built.
This PR considers:

  • Connected ES is newer major (warn: pipelines using new features won't work)
  • Connected ES is older major (warn: pipelines using deprecated-in-old-major removed-in-new-major options will fail to load)
  • Connected ES is same major, but:
    • Connected ES is newer minor (warn: pipelines using new features won't work)
    • Connected ES is older minor (info: low-risk mismatch)
    • Connected ES is same minor (debug: everything is okay)

Example results

  • When plugin and ES major.minor versions are same
[2025-01-22T15:11:12,861][INFO ][logstash.filters.elasticintegration][main] This 8.17.0 version of plugin embedded Ingest node components from Elasticsearch 8.17
  • When plugin minor version is ahead of ES minor version
2025-01-22T15:16:57,997][INFO ][logstash.filters.elasticintegration][main] This 8.18.0 version of plugin embedded Ingest node components from Elasticsearch 8.18
[2025-01-22T15:16:57,997][INFO ][logstash.filters.elasticintegration][main] This 8.18.0 version of plugin is compiled with newer Elasticsearch version than currently connected Elasticsearch 8.17 version
  • When plugin major version is ahead of ES major version
[2025-01-22T15:27:06,285][INFO ][logstash.filters.elasticintegration][main] This 9.0.0 version of plugin embedded Ingest node components from Elasticsearch 9.0
[2025-01-22T15:27:06,285][INFO ][logstash.filters.elasticintegration][main] This 9.0.0 version of plugin is compiled with newer Elasticsearch version than currently connected Elasticsearch 8.17 version. Upgrade the plugin and/or stack to the same `major.minor` to get the minimal disruptive experience.

- When plugin major version is behind of ES major version
[2025-01-22T15:28:59,232][INFO ][logstash.filters.elasticintegration][main] This 8.17.0 version of plugin embedded Ingest node components from Elasticsearch 8.17
[2025-01-22T15:28:59,233][WARN ][logstash.filters.elasticintegration][main] This 8.17.0 version of plugin is compiled with older Elasticsearch version than currently connected Elasticsearch 9.0 version. Upgrade the plugin and/or stack to the same `major.minor` to get the minimal disruptive experience.
  • When plugin minor version is behind of ES minor version
[2025-01-23T07:23:26,577][INFO ][logstash.filters.elasticintegration][main] This 8.16.0 version of plugin embedded Ingest node components from Elasticsearch 8.16
[2025-01-23T07:23:26,595][INFO ][logstash.filters.elasticintegration][main] This 8.16.0 version of plugin is compiled with older Elasticsearch version than currently connected Elasticsearch 8.17 version. Upgrade the plugin and/or stack to the same `major.minor` to get the minimal disruptive experience

… version (#247)

* Logging improvements: informing which ES version considered when building this plugin version, when plugin and connected ES versions do not match warn/inform incompatibility risk and show the guidance.

* Preflight check initialization optimization.

* Refactored messages in a way for better visibility. Any major mismatch is warning and connected ES minor ahead is warning as well.

Co-authored-by: Ry Biesemeyer <[email protected]>

* Standardize log outputs on console.

---------

Co-authored-by: Ry Biesemeyer <[email protected]>
(cherry picked from commit 021e8c7)
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jan 27, 2025

Copy link
Collaborator

@mashhurs mashhurs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Unit test cases will be fixed by #254

@mashhurs mashhurs merged commit b5b9822 into 8.x Jan 28, 2025
1 of 2 checks passed
@mashhurs mashhurs deleted the backport_247_8.x branch January 28, 2025 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants