Skip to content

Conversation

mashhurs
Copy link
Collaborator

@mashhurs mashhurs commented Mar 23, 2025

Our understanding of '--skip-setup' action='store_true' seems incorrect that E2E CIs (example) running with --skip-setup=True.
When I take a look at the store_true, it seems it automatically stores the default False value: https://hg.python.org/cpython/file/2.7/Lib/argparse.py#l861

Similar discussion can be seen here: https://stackoverflow.com/a/8203679

@mashhurs mashhurs requested a review from donoghuc March 23, 2025 04:00
Copy link

mergify bot commented Mar 23, 2025

This pull request does not have a backport label. Could you fix it @mashhurs? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • backport-8.x is the label to automatically backport to the 8.x branch.
  • If no backport is necessary, please add the backport-skip label

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

@mashhurs
Copy link
Collaborator Author

@v1v I am not able to see the backport-skip label. Do we need to manually create it? If it is up to Mergify, can you please check what happened?
image

@v1v
Copy link
Member

v1v commented Mar 23, 2025

Likely it was not created either manually or in the automation. Mergify does not create them.

For the record, we have centralised the github labels for some projects, and I think the backport-skip was not in that list. That's fine, you can create it manually or wait for my contribution to the elastic/observability-dev repository to actually create that label - as you prefer. Thanks for the heads up 🙏

@mashhurs mashhurs added the backport-skip Skip automated backport with mergify label Mar 24, 2025
@mashhurs
Copy link
Collaborator Author

Likely it was not created either manually or in the automation. Mergify does not create them.

For the record, we have centralised the github labels for some projects, and I think the backport-skip was not in that list. That's fine, you can create it manually or wait for my contribution to the elastic/observability-dev repository to actually create that label - as you prefer. Thanks for the heads up 🙏

Now it is here. Thank you alot!

Copy link
Member

@donoghuc donoghuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, my bad. Yeah the "store_" action indicates what will be stored WHEN the flag is set. So in this case when --skip-setup is present, the value is True. When i first read that I thout the store_ action indicated the default value. Its the opposite 🤦

@mashhurs mashhurs merged commit 34188e7 into elastic:main Mar 24, 2025
5 checks passed
@mashhurs mashhurs deleted the fix-skip-setup-issue branch March 24, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-skip Skip automated backport with mergify

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants