Skip to content

Commit 3ca7395

Browse files
authored
simplify x-pack/build.gradle (#18381)
There is no need to apply rubyUtils.gradle to `x-pack/build.gralde`, which defined the entire set of tasks from the former into the latter. This can lead to confusing situations like running `./gradlew downloadAndInstallJRuby` installing JRuby twice (once in project root and another in x-pack/) since gradle will run all tasks matching that name.
1 parent d9fda37 commit 3ca7395

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

x-pack/build.gradle

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
description = """Logstash X-Pack"""
88

99
project.ext.LOGSTASH_CORE_PATH = "${projectDir}/../logstash-core"
10-
apply from: "../rubyUtils.gradle"
1110

1211
repositories {
1312
mavenCentral()
@@ -62,7 +61,7 @@ tasks.register("rubyIntegrationTests", Test) {
6261
}
6362
testClassesDirs = sourceSets.test.output.classesDirs
6463
classpath = sourceSets.test.runtimeClasspath
65-
dependsOn (":copyEs")
64+
dependsOn ":copyEs"
6665
dependsOn ":assemble"
6766
dependsOn "buildFipsValidationGem"
6867
inputs.files fileTree("${projectDir}/qa")

0 commit comments

Comments
 (0)