Skip to content

Commit 3f6f66d

Browse files
mashhursyaauie
andcommitted
Apply suggestions from code review
[doc] better explanation of accepting key format. Co-authored-by: Rye Biesemeyer <[email protected]>
1 parent 440e894 commit 3f6f66d

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

docs/reference/keystore.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ bin/logstash-keystore add ES_USER ES_PWD
136136
When prompted, enter a value for each key.
137137
138138
::::{note}
139-
Key values are limited to ASCII characters. It can only accept digits, letters and optional `.` (dots) and/or `_` (underscores) symbols included between or after.
139+
Key values are limited to ASCII letters (`a`-`z`, `A`-`Z`), numbers (`0`-`9`), underscores (`_`), and dots (`.`); they must be at least one character long and cannot begin with a number.
140140
::::
141141
142142

logstash-core/src/main/java/org/logstash/secret/SecretIdentifier.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ private static String validateWithTransform(final String key, final String partN
7979
}
8080

8181
if (!KEY_PATTERN.matcher(key).matches()) {
82-
logger.warn(String.format("Invalid %s key appeared in keystore. Please remove it as it cannot be used in the pipelines", key));
82+
logger.warn(String.format("Invalid `%s` key appeared in keystore. Please remove it as it cannot be used in the pipelines", key));
8383
}
8484
return key.toLowerCase(Locale.US);
8585
}

0 commit comments

Comments
 (0)