Skip to content

Commit 554f9a5

Browse files
[8.18] (backport #17978) Start all exhastive tests in parallel (#17983)
* Start all exhastive tests in parallel (#17978) Previously the package based tests would be blocked on the pull request suite. Given those tests MUST have be run to even get code in to a branch this results in the exhaustive test suite taking roughly 30 mins to even start the unique tests. In practice when we want to reproduce or test a failure in the exhaustive suite we DONT want to be blocked on seeing the PR tests. This commit removes the depends-on condition for the package based tests on the pull request tests. It does not seem like any protection from doing unncessary package based tests if a pull request test fails is worth the extra wall time in practice. This should significantly decrease the total time needed for the exhaustive test pipeline. (cherry picked from commit 332355d) # Conflicts: # .buildkite/scripts/exhaustive-tests/generate-steps.py * fix merge conflict --------- Co-authored-by: Cas Donoghue <[email protected]>
1 parent 86e90f7 commit 554f9a5

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

.buildkite/scripts/exhaustive-tests/generate-steps.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -182,36 +182,32 @@ def acceptance_docker_steps()-> list[typing.Any]:
182182
structure = {"steps": []}
183183

184184
structure["steps"].append({
185-
"group": "Testing Phase",
185+
"group": "Pull request suite",
186186
"key": "testing-phase",
187187
**testing_phase_steps(),
188188
})
189189

190190
structure["steps"].append({
191191
"group": "Compatibility / Linux",
192192
"key": "compatibility-linux",
193-
"depends_on": "testing-phase",
194193
"steps": compat_linux_steps,
195194
})
196195

197196
structure["steps"].append({
198197
"group": "Compatibility / Windows",
199198
"key": "compatibility-windows",
200-
"depends_on": "testing-phase",
201199
"steps": [compat_windows_step(imagesuffix=windows_test_os)],
202200
})
203201

204202
structure["steps"].append({
205203
"group": "Acceptance / Packaging",
206204
"key": "acceptance-packaging",
207-
"depends_on": ["testing-phase"],
208205
"steps": acceptance_linux_steps(),
209206
})
210207

211208
structure["steps"].append({
212209
"group": "Acceptance / Docker",
213210
"key": "acceptance-docker",
214-
"depends_on": ["testing-phase"],
215211
"steps": acceptance_docker_steps(),
216212
})
217213

0 commit comments

Comments
 (0)