-
Notifications
You must be signed in to change notification settings - Fork 55
Description
Bug Report
Which version of the demo you are using?
be48109
Symptom
We currently have a github workflow to sync with upstream, see here, this is disabled atm as this fails. The failure is due to merge conflicts.
What is the expected behavior?
Expect that the sync is successful
What is the actual behavior?
Sync with upstream fails with merge conflicts
Reproduce
You can view the Scheduled Merge upstream here.
Additional Context
This is usually due to the package.lock.json causing conflicts, this is because the payment service in the elastic otel demo contains a elastic specific dependency compaired to upstream, see here.
Proposed fix
First fix the payment service issue by using npm install on sync to fix conflicts?
Remove the sync job and automate a PR to open once a week to do the sync, the merge can be automated if no conflicts are present.
Tip: React with 👍 to help prioritize this issue. Please use comments to provide useful context, avoiding +1 or me too, to help us triage it. Learn more here.