Skip to content

Conversation

@natasha-moore-elastic
Copy link
Contributor

Contributes to https://github.com/elastic/security-docs-internal/issues/48.

Add callouts to the asciidoc API docs to direct users to the new API reference site, in preparation for retiring the asciidoc API docs.

NOTE: The api-kibana variable is defined in version-specific files. In 8.15.asciidoc and 8.x.asciidoc, the variable points to the v8 branch of the API reference, which currently doesn't include Security API docs. The v8 branch is derived from the "current" Kibana branch, which is currently 8.15. This likely means that we can only backport the callouts to 8.16 once 8.16 becomes the "current" docs version.

@natasha-moore-elastic natasha-moore-elastic added API Priority: Medium Issues that have relevance, but aren't urgent Effort: Medium Issues that take moderate but not substantial time to complete Docset: ESS Issues that apply to docs in the Stack release v8.16.0 labels Oct 10, 2024
@natasha-moore-elastic natasha-moore-elastic self-assigned this Oct 10, 2024
@github-actions
Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@natasha-moore-elastic natasha-moore-elastic marked this pull request as ready for review October 10, 2024 17:10
@natasha-moore-elastic natasha-moore-elastic requested a review from a team as a code owner October 10, 2024 17:10
Copy link
Contributor

@nastasha-solomon nastasha-solomon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spot-checked a few pages and skimmed the changed files tab. Everything looks great! Thanks for adding these banners, @natasha-moore-elastic!

@natasha-moore-elastic natasha-moore-elastic merged commit 2d2a22b into main Oct 11, 2024
2 checks passed
mergify bot pushed a commit that referenced this pull request Oct 11, 2024
@natasha-moore-elastic
Copy link
Contributor Author

@Mergifyio backport 8.16.0

@mergify
Copy link
Contributor

mergify bot commented Nov 13, 2024

backport 8.16.0

❌ No backport have been created

  • Backport to branch 8.16.0 failed

GitHub error: Branch not found

@natasha-moore-elastic
Copy link
Contributor Author

https://github.com/Mergifyio backport 8.16

@mergify
Copy link
Contributor

mergify bot commented Nov 13, 2024

backport 8.16

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 13, 2024
(cherry picked from commit 2d2a22b)

# Conflicts:
#	docs/advanced-entity-analytics/api/asset-criticality-api-overview.asciidoc
natasha-moore-elastic added a commit that referenced this pull request Nov 13, 2024
* Direct users to new API reference site (#5911)

(cherry picked from commit 2d2a22b)

# Conflicts:
#	docs/advanced-entity-analytics/api/asset-criticality-api-overview.asciidoc

* resolves conflict

---------

Co-authored-by: natasha-moore-elastic <[email protected]>
Co-authored-by: natasha-moore-elastic <[email protected]>
natasha-moore-elastic added a commit that referenced this pull request Nov 13, 2024
(cherry picked from commit 2d2a22b)

Co-authored-by: natasha-moore-elastic <[email protected]>
acorretti pushed a commit that referenced this pull request Nov 19, 2024
(cherry picked from commit bf56e06)

# Conflicts:
#	docs/advanced-entity-analytics/api/asset-criticality-api-overview.asciidoc
acorretti pushed a commit that referenced this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API Docset: ESS Issues that apply to docs in the Stack release Effort: Medium Issues that take moderate but not substantial time to complete Priority: Medium Issues that have relevance, but aren't urgent v8.16.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants