Skip to content

Conversation

@rseldner
Copy link
Contributor

@rseldner rseldner commented Oct 14, 2024

Explicitly noted block listed files are quarantined

Previews:

…ocklisted files

Explicitly noted block listed files are quarantined
@rseldner rseldner added documentation Improvements or additions to documentation Team: Docs labels Oct 14, 2024
@rseldner rseldner requested a review from a team as a code owner October 14, 2024 14:52
@github-actions
Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@mergify

This comment was marked as resolved.

gabriellandau
gabriellandau previously approved these changes Oct 14, 2024
@joepeeples
Copy link
Contributor

Thanks for this update, @rseldner! I added a commit to update the same content in our serverless docs, and also added some labels to trigger backports to several recent versions. I'll handle merging and everything from here on out.

@joepeeples joepeeples requested a review from a team October 16, 2024 14:17
@joepeeples joepeeples enabled auto-merge (squash) October 16, 2024 14:17
@elasticdocs
Copy link

🚀 Built elastic-dot-co-docs-preview-docs successfully!

Issues? Visit #next-docs in Slack

Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, super trivial thing is that the link "blocklist" is in italics on the serverless version

@joepeeples joepeeples merged commit 6e01499 into main Oct 16, 2024
6 checks passed
mergify bot pushed a commit that referenced this pull request Oct 16, 2024
* Update configure-integration-policy.asciidoc - Noted we quarantine blocklisted files

Explicitly noted block listed files are quarantined

* Fix typo

* Apply change to serverless docs

---------

Co-authored-by: Joe Peeples <[email protected]>
(cherry picked from commit 6e01499)

# Conflicts:
#	docs/serverless/edr-install-config/configure-endpoint-integration-policy.mdx
mergify bot pushed a commit that referenced this pull request Oct 16, 2024
* Update configure-integration-policy.asciidoc - Noted we quarantine blocklisted files

Explicitly noted block listed files are quarantined

* Fix typo

* Apply change to serverless docs

---------

Co-authored-by: Joe Peeples <[email protected]>
(cherry picked from commit 6e01499)

# Conflicts:
#	docs/serverless/edr-install-config/configure-endpoint-integration-policy.mdx
mergify bot pushed a commit that referenced this pull request Oct 16, 2024
* Update configure-integration-policy.asciidoc - Noted we quarantine blocklisted files

Explicitly noted block listed files are quarantined

* Fix typo

* Apply change to serverless docs

---------

Co-authored-by: Joe Peeples <[email protected]>
(cherry picked from commit 6e01499)

# Conflicts:
#	docs/serverless/edr-install-config/configure-endpoint-integration-policy.mdx
joepeeples pushed a commit that referenced this pull request Oct 16, 2024
…#5937)

* [doc] Noted blocklisted files are quarantined (#5918)

* Update configure-integration-policy.asciidoc - Noted we quarantine blocklisted files

Explicitly noted block listed files are quarantined

* Fix typo

* Apply change to serverless docs

---------

Co-authored-by: Joe Peeples <[email protected]>
(cherry picked from commit 6e01499)

# Conflicts:
#	docs/serverless/edr-install-config/configure-endpoint-integration-policy.mdx

* Delete docs/serverless directory and its contents

---------

Co-authored-by: Roberto Seldner <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joepeeples pushed a commit that referenced this pull request Oct 16, 2024
…5935)

* [doc] Noted blocklisted files are quarantined (#5918)

* Update configure-integration-policy.asciidoc - Noted we quarantine blocklisted files

Explicitly noted block listed files are quarantined

* Fix typo

* Apply change to serverless docs

---------

Co-authored-by: Joe Peeples <[email protected]>
(cherry picked from commit 6e01499)

# Conflicts:
#	docs/serverless/edr-install-config/configure-endpoint-integration-policy.mdx

* Delete docs/serverless directory and its contents

---------

Co-authored-by: Roberto Seldner <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@joepeeples joepeeples deleted the rseldner-patch-1 branch October 16, 2024 15:12
@joepeeples
Copy link
Contributor

joepeeples commented Oct 16, 2024

LGTM, super trivial thing is that the link "blocklist" is in italics on the serverless version

@benironside I think that's on the ESS version, and it's a quirk of Asciidoctor that sometimes (but not always?) italicizes a cross-reference when you don't define specific link text. There doesn't seem to be a way to alter this, other than explicitly add link text every time, which sometimes is a bit unnecessary.

joepeeples pushed a commit that referenced this pull request Oct 16, 2024
…#5936)

* [doc] Noted blocklisted files are quarantined (#5918)

* Update configure-integration-policy.asciidoc - Noted we quarantine blocklisted files

Explicitly noted block listed files are quarantined

* Fix typo

* Apply change to serverless docs

---------

Co-authored-by: Joe Peeples <[email protected]>
(cherry picked from commit 6e01499)

# Conflicts:
#	docs/serverless/edr-install-config/configure-endpoint-integration-policy.mdx

* Delete docs/serverless directory and its contents

---------

Co-authored-by: Roberto Seldner <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation Team: Docs v8.14.0 v8.15.0 v8.16.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants