fix some tests

Author: emilioalvap

__tests__/options.test.ts

@@ -196,11 +196,13 @@ describe('options', () => {
   describe('parseFileOption', () => {
     it('parses file', () => {
       expect(
-        parseFileOption(join(__dirname, 'fixtures', 'synthetics.config.ts'))
+        parseFileOption('test')(
+          join(__dirname, 'fixtures', 'synthetics.config.ts')
+        )
       ).toBeInstanceOf(Buffer);
     });
     it('parses string', () => {
-      expect(parseFileOption('test')).toEqual('test');
+      expect(parseFileOption('test')('test')).toEqual('test');
     });
   });
 

src/cli.ts

@@ -305,12 +305,12 @@ program
   .option(
     '--proxy-ca <path>',
     'provide a CA override for proxy endpoint, as a path to be loaded or as string',
-    collectOpts('ca', proxySettings, parseFileOption)
+    collectOpts('ca', proxySettings, parseFileOption('--proxy-ca'))
   )
   .option(
     '--proxy-cert <path>',
     'provide a cert override for proxy endpoint, as a path to be loaded or as string',
-    collectOpts('cert', proxySettings, parseFileOption)
+    collectOpts('cert', proxySettings, parseFileOption('--proxy-cert'))
   )
   .option(
     '--proxy-no-verify',

src/options.ts

@@ -28,7 +28,6 @@ import { createOption } from 'commander';
 import { readConfig } from './config';
 import type { CliArgs, RunOptions } from './common_types';
 import { isFile, THROTTLING_WARNING_MSG, warn } from './helpers';
-import path from 'path';
 import { readFileSync } from 'fs';
 
 type Mode = 'run' | 'push';
@@ -305,18 +304,18 @@ function parseAsBuffer(value: any): Buffer {
   }
 }
 
-export function parseFileOption(value: string) {
-  const filePath = path.resolve(value);
-
-  if (!isFile(filePath)) {
-    return value;
-  }
+export function parseFileOption(opt: string) {
+  return (value: string) => {
+    if (!isFile(value)) {
+      return value;
+    }
 
-  try {
-    return readFileSync(filePath);
-  } catch (e) {
-    throw new Error(`could not be read provided path ${filePath}: ${e}`);
-  }
+    try {
+      return readFileSync(value);
+    } catch (e) {
+      throw new Error(`${opt} - could not read provided path ${value}: ${e}`);
+    }
+  };
 }
 
 // This is a generic util to collect multiple options into a single