Only set kql custom indicator filter if it exists (#1354)

* Only set kql custom indicator filter if it exists

* Update changelog

Author: nick-benoit

CHANGELOG.md

@@ -1,6 +1,7 @@
 ## [Unreleased]
 
 - Fix provider crash with `elasticstack_kibana_action_connector` when `config` or `secrets` was unset in 0.11.17 ([#1355](https://github.com/elastic/terraform-provider-elasticstack/pull/1355))
+- Fixes provider crash with `elasticstack_kibana_slo` when using `kql_custom_indicator` with no `filter` set.
 
 ## [0.11.18] - 2025-10-10
 

internal/kibana/slo.go

@@ -1019,11 +1019,15 @@ func resourceSloRead(ctx context.Context, d *schema.ResourceData, meta interface
 		params := s.Indicator.IndicatorPropertiesCustomKql.Params
 		indicatorMap := map[string]interface{}{
 			"index":           params.Index,
-			"filter":          params.Filter.String,
 			"good":            params.Good.String,
 			"total":           params.Total.String,
 			"timestamp_field": params.TimestampField,
 		}
+
+		if params.Filter != nil && params.Filter.String != nil {
+			indicatorMap["filter"] = params.Filter.String
+		}
+
 		if params.DataViewId != nil {
 			indicatorMap["data_view_id"] = *params.DataViewId
 		}

internal/kibana/slo_test.go

@@ -736,6 +736,58 @@ func TestAccResourceSloValidation(t *testing.T) {
 	})
 }
 
+func TestAccResourceSlo_kql_custom_indicator_basic(t *testing.T) {
+	sloName := sdkacctest.RandStringFromCharSet(22, sdkacctest.CharSetAlphaNum)
+	resource.Test(t, resource.TestCase{
+		PreCheck:     func() { acctest.PreCheck(t) },
+		CheckDestroy: checkResourceSloDestroy,
+		Steps: []resource.TestStep{
+			{
+				ProtoV6ProviderFactories: acctest.Providers,
+				SkipFunc:                 versionutils.CheckIfVersionIsUnsupported(sloTimesliceMetricsMinVersion),
+				Config: fmt.Sprintf(`
+					provider "elasticstack" {
+						elasticsearch {}
+						kibana {}
+					}
+
+					resource "elasticstack_elasticsearch_index" "my_index" {
+						name = "my-index-%s"
+						deletion_protection = false
+					}
+                    resource "elasticstack_kibana_slo" "test_slo" {
+						name        = "%s"
+						description = "basic kql indicator"
+		                kql_custom_indicator {
+		                	index = "my-index-%s"
+		                	good = "latency < 300"
+		                	total = "*"
+		                	timestamp_field = "custom_timestamp"
+		                }
+						budgeting_method = "timeslices"
+						objective {
+							target           = 0.95
+							timeslice_target = 0.95
+							timeslice_window = "5m"
+						}
+						time_window {
+							duration = "7d"
+							type     = "rolling"
+						}
+						depends_on = [elasticstack_elasticsearch_index.my_index]
+					}
+				`, sloName, sloName, sloName),
+				Check: resource.ComposeTestCheckFunc(
+					resource.TestCheckResourceAttr("elasticstack_kibana_slo.test_slo", "kql_custom_indicator.0.index", "my-index-"+sloName),
+					resource.TestCheckResourceAttr("elasticstack_kibana_slo.test_slo", "kql_custom_indicator.0.good", "latency < 300"),
+					resource.TestCheckResourceAttr("elasticstack_kibana_slo.test_slo", "kql_custom_indicator.0.total", "*"),
+					resource.TestCheckResourceAttr("elasticstack_kibana_slo.test_slo", "kql_custom_indicator.0.timestamp_field", "custom_timestamp"),
+				),
+			},
+		},
+	})
+}
+
 func TestSloIdValidation(t *testing.T) {
 	resource := kibanaresource.ResourceSlo()
 	sloIdSchema := resource.Schema["slo_id"]