add iso8601 validation

Author: adcoelho

internal/kibana/maintenance_window/schema.go

@@ -57,6 +57,9 @@ func (r *MaintenanceWindowResource) Schema(_ context.Context, _ resource.SchemaR
 					"start": schema.StringAttribute{
 						Description: "The start date and time of the schedule, provided in ISO 8601 format and set to the UTC timezone. For example: `2025-03-12T12:00:00.000Z`.",
 						Required:    true,
+						Validators: []validator.String{
+							validation_utils.StringIsISO8601{},
+						},
 					},
 					"duration": schema.StringAttribute{
 						Description: "The duration of the schedule. It allows values in `<integer><unit>` format. `<unit>` is one of `d`, `h`, `m`, or `s` for hours, minutes, seconds. For example: `1d`, `5h`, `30m`, `5000s`.",
@@ -77,6 +80,9 @@ func (r *MaintenanceWindowResource) Schema(_ context.Context, _ resource.SchemaR
 							"end": schema.StringAttribute{
 								Description: "The end date and time of the schedule, provided in ISO 8601 format and set to the UTC timezone. For example: `2025-03-12T12:00:00.000Z`.",
 								Optional:    true,
+								Validators: []validator.String{
+									validation_utils.StringIsISO8601{},
+								},
 							},
 							"every": schema.StringAttribute{
 								Description: "The duration of the schedule. It allows values in `<integer><unit>` format. `<unit>` is one of `d`, `h`, `m`, or `s` for hours, minutes, seconds. For example: `1d`, `5h`, `30m`, `5000s`.",

internal/kibana/utils/validators.go

@@ -108,3 +108,33 @@ func StringIsAlertingDurationSDKV2() schema.SchemaValidateFunc {
 	r := regexp.MustCompile(alertingDurationPattern)
 	return validation.StringMatch(r, "string is not a valid Alerting duration in seconds (s), minutes (m), hours (h), or days (d)")
 }
+
+func StringMatchesISO8601Regex(s string) (matched bool, err error) {
+	pattern := `(\d{4}-[01]\d-[0-3]\dT[0-2]\d:[0-5]\d:[0-5]\d\.\d+([+-][0-2]\d:[0-5]\d|Z))|(\d{4}-[01]\d-[0-3]\dT[0-2]\d:[0-5]\d:[0-5]\d([+-][0-2]\d:[0-5]\d|Z))|(\d{4}-[01]\d-[0-3]\dT[0-2]\d:[0-5]\d([+-][0-2]\d:[0-5]\d|Z))`
+	return regexp.MatchString(pattern, s)
+}
+
+type StringIsISO8601 struct{}
+
+func (s StringIsISO8601) Description(_ context.Context) string {
+	return "a valid ISO8601 date and time formatted string"
+}
+
+func (s StringIsISO8601) MarkdownDescription(ctx context.Context) string {
+	return s.Description(ctx)
+}
+
+func (s StringIsISO8601) ValidateString(_ context.Context, req validator.StringRequest, resp *validator.StringResponse) {
+	if req.ConfigValue.IsNull() || req.ConfigValue.IsUnknown() {
+		return
+	}
+
+	if matched, err := StringMatchesISO8601Regex(req.ConfigValue.ValueString()); err != nil || !matched {
+		resp.Diagnostics.AddAttributeError(
+			req.Path,
+			"expected value to be a valid ISO8601 string",
+			fmt.Sprintf("This value must be a valid ISO8601 date and time formatted string %s", err),
+		)
+		return
+	}
+}

internal/kibana/utils/validators_test.go

@@ -40,6 +40,75 @@ func TestStringMatchesAlertingDuration(t *testing.T) {
 	}
 }
 
+func TestStringMatchesISO8601(t *testing.T) {
+	t.Parallel()
+
+	tests := []struct {
+		name    string
+		date    string
+		matched bool
+	}{
+		{
+			name:    "valid complete date 1",
+			date:    "1994-11-05T13:15:30Z",
+			matched: true,
+		},
+		{
+			name:    "valid complete date 2",
+			date:    "1997-07-04T19:20+01:00",
+			matched: true,
+		},
+		{
+			name:    "valid complete date 3",
+			date:    "1994-11-05T08:15:30-05:00",
+			matched: true,
+		},
+		{
+			name:    "valid complete date plus hours, minutes and seconds",
+			date:    "1997-07-16T19:20:30+01:00",
+			matched: true,
+		},
+		{
+			name:    "valid complete date plus hours, minutes, seconds and a decimal fraction of a second",
+			date:    "1997-07-16T19:20:30.45+01:00",
+			matched: true,
+		}, {
+			name:    "invalid year",
+			date:    "1997",
+			matched: false,
+		},
+		{
+			name:    "invalid year and month",
+			date:    "1997-07",
+			matched: false,
+		},
+		{
+			name:    "invalid complete date",
+			date:    "1997-07-04",
+			matched: false,
+		},
+		{
+			name:    "invalid hours and minutes",
+			date:    "1997-40-04T30:220+01:00",
+			matched: false,
+		},
+		{
+			name:    "invalid  seconds",
+			date:    "1997-07-16T19:20:80+01:00",
+			matched: false,
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			matched, _ := StringMatchesISO8601Regex(tt.date)
+			if !reflect.DeepEqual(matched, tt.matched) {
+				t.Errorf("StringMatchesISO8601Regex() failed match = %v, want %v", matched, tt.matched)
+			}
+		})
+	}
+}
+
 func TestStringMatchesOnWeekDay(t *testing.T) {
 	t.Parallel()