Copilot PR feedback

Author: nick-benoit

internal/kibana/security_list/models.go

@@ -3,6 +3,7 @@ package security_list
 import (
 	"context"
 	"encoding/json"
+	"time"
 
 	"github.com/elastic/terraform-provider-elasticstack/generated/kbapi"
 	"github.com/hashicorp/terraform-plugin-framework/diag"
@@ -96,7 +97,7 @@ func (m *SecurityListModel) toUpdateRequest() (*kbapi.UpdateListJSONRequestBody,
 	}
 
 	if !m.Version.IsNull() && !m.Version.IsUnknown() {
-		version := kbapi.SecurityListsAPIListVersion(m.Version.ValueInt64())
+		version := kbapi.SecurityListsAPIListVersion(int(m.Version.ValueInt64()))
 		req.Version = &version
 	}
 
@@ -115,9 +116,9 @@ func (m *SecurityListModel) fromAPI(ctx context.Context, apiList *kbapi.Security
 	m.Immutable = types.BoolValue(apiList.Immutable)
 	m.Version = types.Int64Value(int64(apiList.Version))
 	m.TieBreakerID = types.StringValue(apiList.TieBreakerId)
-	m.CreatedAt = types.StringValue(apiList.CreatedAt.String())
+	m.CreatedAt = types.StringValue(apiList.CreatedAt.Format(time.RFC3339))
 	m.CreatedBy = types.StringValue(apiList.CreatedBy)
-	m.UpdatedAt = types.StringValue(apiList.UpdatedAt.String())
+	m.UpdatedAt = types.StringValue(apiList.UpdatedAt.Format(time.RFC3339))
 	m.UpdatedBy = types.StringValue(apiList.UpdatedBy)
 
 	// Set optional _version field

internal/kibana/security_list/read.go

@@ -22,10 +22,9 @@ func (r *securityListResource) Read(ctx context.Context, req resource.ReadReques
 	}
 
 	spaceID := state.SpaceID.ValueString()
-	listID := state.ListID.ValueString()
 
 	params := &kbapi.ReadListParams{
-		Id: kbapi.SecurityListsAPIListId(listID),
+		Id: kbapi.SecurityListsAPIListId(state.ID.ValueString()),
 	}
 
 	readResp, diags := kibana_oapi.GetList(ctx, client, spaceID, params)

internal/kibana/security_list/schema.go

@@ -26,7 +26,6 @@ func (r *securityListResource) Schema(_ context.Context, _ resource.SchemaReques
 				Optional:            true,
 				PlanModifiers: []planmodifier.String{
 					stringplanmodifier.RequiresReplace(),
-					stringplanmodifier.UseStateForUnknown(),
 				},
 			},
 			"space_id": schema.StringAttribute{

internal/kibana/security_list/update.go

@@ -21,11 +21,6 @@ func (r *securityListResource) Update(ctx context.Context, req resource.UpdateRe
 		return
 	}
 
-	// Preserve version_id from state for optimistic locking
-	if state.VersionID.ValueString() != "" {
-		plan.VersionID = state.VersionID
-	}
-
 	// Convert plan to API request
 	updateReq, diags := plan.toUpdateRequest()
 	resp.Diagnostics.Append(diags...)