Use new helpers for type casting

Author: nick-benoit

internal/kibana/security_list/models.go

@@ -112,11 +112,11 @@ func (m *SecurityListModel) toUpdateRequest() (*kbapi.UpdateListJSONRequestBody,
 func (m *SecurityListModel) fromAPI(ctx context.Context, apiList *kbapi.SecurityListsAPIList) diag.Diagnostics {
 	var diags diag.Diagnostics
 
-	m.ID = types.StringValue(string(apiList.Id))
-	m.ListID = types.StringValue(string(apiList.Id))
-	m.Name = types.StringValue(string(apiList.Name))
-	m.Description = types.StringValue(string(apiList.Description))
-	m.Type = types.StringValue(string(apiList.Type))
+	m.ID = utils.StringishValue(apiList.Id)
+	m.ListID = utils.StringishValue(apiList.Id)
+	m.Name = utils.StringishValue(apiList.Name)
+	m.Description = utils.StringishValue(apiList.Description)
+	m.Type = utils.StringishValue(apiList.Type)
 	m.Immutable = types.BoolValue(apiList.Immutable)
 	m.Version = types.Int64Value(int64(apiList.Version))
 	m.TieBreakerID = types.StringValue(apiList.TieBreakerId)
@@ -127,19 +127,19 @@ func (m *SecurityListModel) fromAPI(ctx context.Context, apiList *kbapi.Security
 
 	// Set optional _version field
 	if apiList.UnderscoreVersion != nil {
-		m.VersionID = types.StringValue(string(*apiList.UnderscoreVersion))
+		m.VersionID = utils.StringishPointerValue(apiList.UnderscoreVersion)
 	} else {
 		m.VersionID = types.StringNull()
 	}
 
 	if apiList.Deserializer != nil {
-		m.Deserializer = types.StringValue(string(*apiList.Deserializer))
+		m.Deserializer = utils.StringishPointerValue(apiList.Deserializer)
 	} else {
 		m.Deserializer = types.StringNull()
 	}
 
 	if apiList.Serializer != nil {
-		m.Serializer = types.StringValue(string(*apiList.Serializer))
+		m.Serializer = utils.StringishPointerValue(apiList.Serializer)
 	} else {
 		m.Serializer = types.StringNull()
 	}

internal/utils/utils.go

@@ -231,3 +231,16 @@ func NonNilSlice[T any](s []T) []T {
 func TimeToStringValue(t time.Time) types.String {
 	return types.StringValue(FormatStrictDateTime(t))
 }
+
+// StringishPointerValue converts a pointer to a string-like type to a Terraform types.String value.
+func StringishPointerValue[T ~string](ptr *T) types.String {
+	if ptr == nil {
+		return types.StringNull()
+	}
+	return types.StringValue(string(*ptr))
+}
+
+// StringishValue converts a value of any string-like type T to a Terraform types.String.
+func StringishValue[T ~string](value T) types.String {
+	return types.StringValue(string(value))
+}