Reject attempts to set supports_agentless when not supported

Author: tobio

internal/clients/api_client.go

@@ -33,6 +33,8 @@ type CompositeId struct {
 	ResourceId string
 }
 
+const ServerlessFlavor = "serverless"
+
 func CompositeIdFromStr(id string) (*CompositeId, diag.Diagnostics) {
 	var diags diag.Diagnostics
 	idParts := strings.Split(id, "/")
@@ -352,6 +354,24 @@ func (a *ApiClient) serverInfo(ctx context.Context) (*models.ClusterInfo, diag.D
 	return &info, diags
 }
 
+func (a *ApiClient) EnforceMinVersion(ctx context.Context, minVersion *version.Version) (bool, diag.Diagnostics) {
+	flavor, diags := a.ServerFlavor(ctx)
+	if diags.HasError() {
+		return false, diags
+	}
+
+	if flavor == ServerlessFlavor {
+		return true, nil
+	}
+
+	serverVersion, diags := a.ServerVersion(ctx)
+	if diags.HasError() {
+		return false, diags
+	}
+
+	return serverVersion.GreaterThanOrEqual(minVersion), nil
+}
+
 func (a *ApiClient) ServerVersion(ctx context.Context) (*version.Version, diag.Diagnostics) {
 	if a.elasticsearch != nil {
 		return a.versionFromElasticsearch(ctx)

internal/elasticsearch/index/index/models.go

@@ -290,7 +290,7 @@ func (model tfModel) toPutIndexParams(serverFlavor string) models.PutIndexParams
 		Timeout:       timeout,
 	}
 
-	if serverFlavor != "serverless" {
+	if serverFlavor != clients.ServerlessFlavor {
 		params.WaitForActiveShards = model.WaitForActiveShards.ValueString()
 	}
 

internal/elasticsearch/index/index/models_test.go

@@ -7,6 +7,7 @@ import (
 
 	fuzz "github.com/google/gofuzz"
 
+	"github.com/elastic/terraform-provider-elasticstack/internal/clients"
 	"github.com/elastic/terraform-provider-elasticstack/internal/models"
 	"github.com/elastic/terraform-provider-elasticstack/internal/utils/customtypes"
 	"github.com/hashicorp/terraform-plugin-framework-jsontypes/jsontypes"
@@ -363,7 +364,7 @@ func Test_tfModel_toPutIndexParams(t *testing.T) {
 
 			flavor := "not_serverless"
 			if isServerless {
-				flavor = "serverless"
+				flavor = clients.ServerlessFlavor
 				expectedParams.WaitForActiveShards = ""
 			}
 

internal/fleet/agent_policy/create.go

@@ -22,12 +22,13 @@ func (r *agentPolicyResource) Create(ctx context.Context, req resource.CreateReq
 		return
 	}
 
-	sVersion, e := r.client.ServerVersion(ctx)
-	if e != nil {
+	feat, diags := r.buildFeatures(ctx)
+	resp.Diagnostics.Append(diags...)
+	if resp.Diagnostics.HasError() {
 		return
 	}
 
-	body, diags := planModel.toAPICreateModel(ctx, sVersion)
+	body, diags := planModel.toAPICreateModel(ctx, feat)
 	resp.Diagnostics.Append(diags...)
 	if resp.Diagnostics.HasError() {
 		return

internal/fleet/agent_policy/models.go

@@ -8,13 +8,17 @@ import (
 	"github.com/elastic/terraform-provider-elasticstack/generated/kbapi"
 	"github.com/elastic/terraform-provider-elasticstack/internal/utils"
 
-	"github.com/hashicorp/go-version"
 	"github.com/hashicorp/terraform-plugin-framework/attr"
 	"github.com/hashicorp/terraform-plugin-framework/diag"
 	"github.com/hashicorp/terraform-plugin-framework/path"
 	"github.com/hashicorp/terraform-plugin-framework/types"
 )
 
+type features struct {
+	SupportsGlobalDataTags    bool
+	SupportsSupportsAgentless bool
+}
+
 type globalDataTagsItemModel struct {
 	StringValue types.String  `tfsdk:"string_value"`
 	NumberValue types.Float32 `tfsdk:"number_value"`
@@ -101,18 +105,18 @@ func (model *agentPolicyModel) populateFromAPI(ctx context.Context, data *kbapi.
 
 // convertGlobalDataTags converts the global data tags from terraform model to API model
 // and performs version validation
-func (model *agentPolicyModel) convertGlobalDataTags(ctx context.Context, serverVersion *version.Version) (*[]kbapi.AgentPolicyGlobalDataTagsItem, diag.Diagnostics) {
+func (model *agentPolicyModel) convertGlobalDataTags(ctx context.Context, feat features) (*[]kbapi.AgentPolicyGlobalDataTagsItem, diag.Diagnostics) {
 	var diags diag.Diagnostics
 
 	if len(model.GlobalDataTags.Elements()) == 0 {
-		if serverVersion.GreaterThanOrEqual(MinVersionGlobalDataTags) {
+		if feat.SupportsGlobalDataTags {
 			emptyList := make([]kbapi.AgentPolicyGlobalDataTagsItem, 0)
 			return &emptyList, diags
 		}
 		return nil, diags
 	}
 
-	if serverVersion.LessThan(MinVersionGlobalDataTags) {
+	if !feat.SupportsGlobalDataTags {
 		diags.AddError("global_data_tags ES version error", fmt.Sprintf("Global data tags are only supported in Elastic Stack %s and above", MinVersionGlobalDataTags))
 		return nil, diags
 	}
@@ -148,7 +152,7 @@ func (model *agentPolicyModel) convertGlobalDataTags(ctx context.Context, server
 	return &itemsList, diags
 }
 
-func (model *agentPolicyModel) toAPICreateModel(ctx context.Context, serverVersion *version.Version) (kbapi.PostFleetAgentPoliciesJSONRequestBody, diag.Diagnostics) {
+func (model *agentPolicyModel) toAPICreateModel(ctx context.Context, feat features) (kbapi.PostFleetAgentPoliciesJSONRequestBody, diag.Diagnostics) {
 	monitoring := make([]kbapi.PostFleetAgentPoliciesJSONBodyMonitoringEnabled, 0, 2)
 
 	if model.MonitorLogs.ValueBool() {
@@ -158,6 +162,16 @@ func (model *agentPolicyModel) toAPICreateModel(ctx context.Context, serverVersi
 		monitoring = append(monitoring, kbapi.PostFleetAgentPoliciesJSONBodyMonitoringEnabledMetrics)
 	}
 
+	if utils.IsKnown(model.SupportsAgentless) && !feat.SupportsSupportsAgentless {
+		return kbapi.PostFleetAgentPoliciesJSONRequestBody{}, diag.Diagnostics{
+			diag.NewAttributeErrorDiagnostic(
+				path.Root("supports_agentless"),
+				"Unsupported Elasticsearch version",
+				fmt.Sprintf("Supports agentless is only supported in Elastic Stack %s and above", MinSupportsAgentlessVersion),
+			),
+		}
+	}
+
 	body := kbapi.PostFleetAgentPoliciesJSONRequestBody{
 		DataOutputId:       model.DataOutputId.ValueStringPointer(),
 		Description:        model.Description.ValueStringPointer(),
@@ -171,7 +185,7 @@ func (model *agentPolicyModel) toAPICreateModel(ctx context.Context, serverVersi
 		SupportsAgentless:  model.SupportsAgentless.ValueBoolPointer(),
 	}
 
-	tags, diags := model.convertGlobalDataTags(ctx, serverVersion)
+	tags, diags := model.convertGlobalDataTags(ctx, feat)
 	if diags.HasError() {
 		return kbapi.PostFleetAgentPoliciesJSONRequestBody{}, diags
 	}
@@ -180,7 +194,7 @@ func (model *agentPolicyModel) toAPICreateModel(ctx context.Context, serverVersi
 	return body, nil
 }
 
-func (model *agentPolicyModel) toAPIUpdateModel(ctx context.Context, serverVersion *version.Version) (kbapi.PutFleetAgentPoliciesAgentpolicyidJSONRequestBody, diag.Diagnostics) {
+func (model *agentPolicyModel) toAPIUpdateModel(ctx context.Context, feat features) (kbapi.PutFleetAgentPoliciesAgentpolicyidJSONRequestBody, diag.Diagnostics) {
 	monitoring := make([]kbapi.PutFleetAgentPoliciesAgentpolicyidJSONBodyMonitoringEnabled, 0, 2)
 	if model.MonitorLogs.ValueBool() {
 		monitoring = append(monitoring, kbapi.Logs)
@@ -189,6 +203,16 @@ func (model *agentPolicyModel) toAPIUpdateModel(ctx context.Context, serverVersi
 		monitoring = append(monitoring, kbapi.Metrics)
 	}
 
+	if utils.IsKnown(model.SupportsAgentless) && !feat.SupportsSupportsAgentless {
+		return kbapi.PutFleetAgentPoliciesAgentpolicyidJSONRequestBody{}, diag.Diagnostics{
+			diag.NewAttributeErrorDiagnostic(
+				path.Root("supports_agentless"),
+				"Unsupported Elasticsearch version",
+				fmt.Sprintf("Supports agentless is only supported in Elastic Stack %s and above", MinSupportsAgentlessVersion),
+			),
+		}
+	}
+
 	body := kbapi.PutFleetAgentPoliciesAgentpolicyidJSONRequestBody{
 		DataOutputId:       model.DataOutputId.ValueStringPointer(),
 		Description:        model.Description.ValueStringPointer(),
@@ -201,7 +225,7 @@ func (model *agentPolicyModel) toAPIUpdateModel(ctx context.Context, serverVersi
 		SupportsAgentless:  model.SupportsAgentless.ValueBoolPointer(),
 	}
 
-	tags, diags := model.convertGlobalDataTags(ctx, serverVersion)
+	tags, diags := model.convertGlobalDataTags(ctx, feat)
 	if diags.HasError() {
 		return kbapi.PutFleetAgentPoliciesAgentpolicyidJSONRequestBody{}, diags
 	}

internal/fleet/agent_policy/resource.go

@@ -5,7 +5,9 @@ import (
 	"fmt"
 
 	"github.com/elastic/terraform-provider-elasticstack/internal/clients"
+	"github.com/elastic/terraform-provider-elasticstack/internal/utils"
 	"github.com/hashicorp/go-version"
+	"github.com/hashicorp/terraform-plugin-framework/diag"
 	"github.com/hashicorp/terraform-plugin-framework/path"
 	"github.com/hashicorp/terraform-plugin-framework/resource"
 )
@@ -16,7 +18,10 @@ var (
 	_ resource.ResourceWithImportState = &agentPolicyResource{}
 )
 
-var MinVersionGlobalDataTags = version.Must(version.NewVersion("8.15.0"))
+var (
+	MinVersionGlobalDataTags    = version.Must(version.NewVersion("8.15.0"))
+	MinSupportsAgentlessVersion = version.Must(version.NewVersion("8.15.0"))
+)
 
 // NewResource is a helper function to simplify the provider implementation.
 func NewResource() resource.Resource {
@@ -40,3 +45,20 @@ func (r *agentPolicyResource) Metadata(ctx context.Context, req resource.Metadat
 func (r *agentPolicyResource) ImportState(ctx context.Context, req resource.ImportStateRequest, resp *resource.ImportStateResponse) {
 	resource.ImportStatePassthroughID(ctx, path.Root("policy_id"), req, resp)
 }
+
+func (r *agentPolicyResource) buildFeatures(ctx context.Context) (features, diag.Diagnostics) {
+	supportsGDT, diags := r.client.EnforceMinVersion(ctx, MinVersionGlobalDataTags)
+	if diags.HasError() {
+		return features{}, utils.FrameworkDiagsFromSDK(diags)
+	}
+
+	supportsSupportsAgentless, diags := r.client.EnforceMinVersion(ctx, MinSupportsAgentlessVersion)
+	if diags.HasError() {
+		return features{}, utils.FrameworkDiagsFromSDK(diags)
+	}
+
+	return features{
+		SupportsGlobalDataTags:    supportsGDT,
+		SupportsSupportsAgentless: supportsSupportsAgentless,
+	}, nil
+}