[Bug] Crash during destroy of elasticstack_kibana_action_connector

[breml]

Describe the bug

While changing an elasticstack_kibana_action_connector for MS Teams (previously created using Terraform), the terraform provider crashed with the output below.
I renamed the terraform resource, which caused Terraform to destroy the old instance and create a new one.
I did some followup changes with the elasticstack_kibana_action_connector, but I was not able to reproduce the crash a second time.

elasticstack_kibana_action_connector.msteams: Destroying... [id=default/8d8576df-aee5-4e29-aaf1-06d536264c57]
elasticstack_kibana_action_connector.msteams-q: Creating...
elasticstack_kibana_action_connector.msteams-p: Creating...
elasticstack_kibana_action_connector.msteams-d: Creating...
elasticstack_kibana_action_connector.msteams: Still destroying... [id=default/8d8576df-aee5-4e29-aaf1-06d536264c57, 10s elapsed]
elasticstack_kibana_action_connector.msteams-p: Still creating... [10s elapsed]
elasticstack_kibana_action_connector.msteams-q: Still creating... [10s elapsed]
elasticstack_kibana_action_connector.msteams-d: Still creating... [10s elapsed]
╷
│ Error: Request cancelled
│
│ The plugin6.(*GRPCProvider).ApplyResourceChange request was cancelled.
╵
╷
│ Error: Request cancelled
│
│ The plugin6.(*GRPCProvider).ApplyResourceChange request was cancelled.
╵
╷
│ Error: Request cancelled
│
│ The plugin6.(*GRPCProvider).ApplyResourceChange request was cancelled.
╵
╷
│ Error: Request cancelled
│
│ The plugin6.(*GRPCProvider).ApplyResourceChange request was cancelled.
╵

Stack trace from the terraform-provider-elasticstack_v0.11.15 plugin:                                                                                                                                                                                                                                                                                                                 panic: runtime error: invalid memory address or nil pointer dereference                                                                                                                    [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x15038a0]                                                                                                                                                                                                                                                                                                               goroutine 52 [running]:                                                                                                                                                                    github.com/elastic/terraform-provider-elasticstack/internal/clients/kibana.DeleteConnector({0x1bfc810?, 0xc0003b6c40?}, 0xc0004ca3c0?, {0xc0000384e8?, 0x29a32e0?}, {0xc000588a40?, 0x29a32e0?})                                                                                                                                                                                              github.com/elastic/terraform-provider-elasticstack/internal/clients/kibana/connector.go:228 +0x7c0
github.com/elastic/terraform-provider-elasticstack/internal/kibana.resourceConnectorDelete({0x1bfc810, 0xc0003b6c40}, 0xc00050b480, {0x190ce00?, 0xc0004ca3c0?})
        github.com/elastic/terraform-provider-elasticstack/internal/kibana/connector.go:214 +0x186
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*Resource).delete(0xc0003bcf00, {0x1bfc768, 0xc0003967b0}, 0xc00050b480, {0x190ce00, 0xc0004ca3c0})
        github.com/hashicorp/terraform-plugin-sdk/v2@v2.36.1/helper/schema/resource.go:889 +0x119
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*Resource).Apply(0xc0003bcf00, {0x1bfc768, 0xc0003967b0}, 0xc0005d4d00, 0xc00050b400, {0x190ce00, 0xc0004ca3c0})
        github.com/hashicorp/terraform-plugin-sdk/v2@v2.36.1/helper/schema/resource.go:938 +0x61a
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*GRPCProviderServer).ApplyResourceChange(0xc0000c5860, {0x1bfc768?, 0xc00027de90?}, 0xc00032d4a0)
        github.com/hashicorp/terraform-plugin-sdk/v2@v2.36.1/helper/schema/grpc_provider.go:1188 +0xd1a
github.com/hashicorp/terraform-plugin-mux/tf5to6server.v5tov6Server.ApplyResourceChange({{0x1c0b048?, 0xc0000c5860?}}, {0x1bfc768, 0xc00027de90}, 0x0?)
        github.com/hashicorp/terraform-plugin-mux@v0.18.0/tf5to6server/tf5to6server.go:38 +0x54
github.com/hashicorp/terraform-plugin-mux/tf6muxserver.(*muxServer).ApplyResourceChange(0xc00026b080, {0x1bfc768?, 0xc00027db30?}, 0xc00032d450)
        github.com/hashicorp/terraform-plugin-mux@v0.18.0/tf6muxserver/mux_server_ApplyResourceChange.go:36 +0x18d
github.com/hashicorp/terraform-plugin-go/tfprotov6/tf6server.(*server).ApplyResourceChange(0xc0003ba8c0, {0x1bfc768?, 0xc000121920?}, 0xc0003b6620)
        github.com/hashicorp/terraform-plugin-go@v0.26.0/tfprotov6/tf6server/server.go:866 +0x3b9
github.com/hashicorp/terraform-plugin-go/tfprotov6/internal/tfplugin6._Provider_ApplyResourceChange_Handler({0x19563c0, 0xc0003ba8c0}, {0x1bfc768, 0xc000121920}, 0xc00050ac00, 0x0)
        github.com/hashicorp/terraform-plugin-go@v0.26.0/tfprotov6/internal/tfplugin6/tfplugin6_grpc.pb.go:611 +0x1a6
google.golang.org/grpc.(*Server).processUnaryRPC(0xc000252a00, {0x1bfc768, 0xc0001218c0}, 0xc000050600, 0xc00047d4d0, 0x2993af8, 0x0)
        google.golang.org/grpc@v1.69.4/server.go:1392 +0xfbe                                                                                                                               google.golang.org/grpc.(*Server).handleStream(0xc000252a00, {0x1bfd668, 0xc00039f860}, 0xc000050600)
        google.golang.org/grpc@v1.69.4/server.go:1802 +0xb88                                                                                                                               google.golang.org/grpc.(*Server).serveStreams.func2.1()                                                                                                                                            google.golang.org/grpc@v1.69.4/server.go:1030 +0x7f                                                                                                                                created by google.golang.org/grpc.(*Server).serveStreams.func2 in goroutine 11                                                                                                                     google.golang.org/grpc@v1.69.4/server.go:1041 +0x11d                                                                                                                                                                                                                                                                                                                          Error: The terraform-provider-elasticstack_v0.11.15 plugin crashed!

This is always indicative of a bug within the plugin. It would be immensely                                                                                                                helpful if you could report the crash with the plugin's maintainers so that it
can be fixed. The output above should help diagnose the issue.

[breml]

@tobio Just tested this one again with a locally built terraform provider, which includes #1260 and the issue is no longer reproducible so I assume, that this one has been fixed by #1260 as well.

[tobio]

Thanks for following up with this one @breml!