Update custom metrics field to be optional
#1065
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the SLO spec to accommodate optional values for the 'field' property in custom metrics SLO configurations. The key changes include:
- Updating the CHANGELOG to note that the 'field' property is now optional.
- Replacing direct type assertions on the 'field' property with the helper function getOrNilString in internal/kibana/slo.go.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| CHANGELOG.md | Added an entry to document making the 'field' optional |
| internal/kibana/slo.go | Modified retrieval of 'field' values to handle nil properly |
wandergeek
changed the title
field to be optional
|
The Kibana spec still lists |
|
So do the published docs |
|
Closing in favor of a larger PR that updates to the latest client |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the SLO spec to make
fieldoptional when dealing with a custom metrics SLO. I have had to make a very unfortunate hack to the client from what appears to be a bug in the generator. It would be good to merge this in now and we can try and fix the upstream issue soon. We are likely due for some more changes to this resource so I think we will need to fix this sooner rather than later.