Add mapping_total_fields_limit #1494
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for the mapping_total_fields_limit setting to the Elasticsearch index resource, addressing issue #333. This setting controls the maximum number of fields allowed in an index.
- Adds the
mapping_total_fields_limitschema attribute to the index resource - Updates the model to include the new field
- Adds the Elasticsearch setting key to the dynamic settings list
- Refactors acceptance tests to use external test data files and config variables
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| internal/elasticsearch/index/index/schema.go | Adds the mapping_total_fields_limit schema attribute definition |
| internal/elasticsearch/index/index/models.go | Adds the field to the tfModel struct and dynamic settings list |
| internal/elasticsearch/index/index/acc_test.go | Refactors tests to use embedded testdata files and config variables; removes inline config function |
| internal/elasticsearch/index/index/testdata/TestAccResourceIndexSettings/create/index.tf | Creates test configuration file with mapping_total_fields_limit set to 2000 |
| internal/elasticsearch/index/index/testdata/TestAccResourceIndexSettings/update/index.tf | Creates test configuration file with mapping_total_fields_limit updated to 3000 |
| internal/elasticsearch/index/index/testdata/TestAccResourceIndexFromSDK/index.tf | Creates test configuration file for SDK migration test without the new field |
| docs/resources/elasticsearch_index.md | Adds documentation for the new mapping_total_fields_limit parameter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #333
Seemed like a quick win to test some instruction changes.