Modernize existing tests. Remove dead code. Resolves #7.

Author: jhorbulyk

.eslintrc.js

@@ -0,0 +1,163 @@
+'use strict';
+
+const OFF = 'off';
+const ERROR = 'error';
+const WARN = 'warn';
+const ALWAYS = 'always';
+const NEVER = 'never';
+
+module.exports = {
+    'parserOptions': {
+        ecmaVersion: 2017
+    },
+    'env': {
+        es6: true,
+        node: true,
+        mocha: true
+    },
+    'plugins': [
+        'mocha'
+    ],
+    'extends': 'eslint:recommended',
+    'rules': {
+        'indent': [
+            ERROR,
+            4,
+            {
+                SwitchCase: 1
+            }
+        ],
+        'linebreak-style': ERROR,
+        'quotes': [
+            WARN,
+            'single',
+            {
+                avoidEscape: true,
+                allowTemplateLiterals: true
+            }
+        ],
+        'semi': [
+            ERROR,
+            ALWAYS
+        ],
+        'func-names': ERROR,
+        'no-var': ERROR,
+        'no-empty': ERROR,
+        'no-empty-function': ERROR,
+        'brace-style': [
+            ERROR,
+            '1tbs',
+            { allowSingleLine: true }
+        ],
+        'no-multiple-empty-lines': ERROR,
+        'no-multi-spaces': ERROR,
+        'one-var': [
+            ERROR,
+            NEVER
+        ],
+        'quote-props': [
+            WARN,
+            'consistent-as-needed'
+        ],
+        'key-spacing': ERROR,
+        'space-unary-ops': [
+            ERROR,
+            {
+                words: true,
+                nonwords: false
+            }
+        ],
+        'no-spaced-func': ERROR,
+        'space-before-function-paren': [
+            ERROR,
+            {
+                anonymous: ALWAYS,
+                named: NEVER
+            }
+        ],
+        'arrow-body-style': [
+            WARN,
+            'as-needed'
+        ],
+        'array-bracket-spacing': ERROR,
+        'space-in-parens': ERROR,
+        'comma-dangle': ERROR,
+        'no-trailing-spaces': ERROR,
+        'yoda': ERROR,
+        'max-len': [
+            ERROR,
+            120
+        ],
+        'camelcase': [
+            ERROR,
+            {
+                properties: 'never'
+            }
+        ],
+        'new-cap': [
+            WARN,
+            {
+                capIsNewExceptions: ['Q']
+            }
+        ],
+        'comma-style': ERROR,
+        'curly': ERROR,
+        'object-curly-spacing': [
+            WARN,
+            ALWAYS
+        ],
+        'object-curly-newline':  [
+            ERROR,
+            {
+                ObjectExpression: {
+                    minProperties: 1
+                },
+                ObjectPattern: {
+                    multiline: true,
+                    minProperties: 5
+                }
+            }
+        ],
+        'object-property-newline': ERROR,
+        'template-curly-spacing': ERROR,
+        'dot-notation': ERROR,
+        'dot-location': [
+            ERROR,
+            'property'
+        ],
+        'func-style': [
+            ERROR,
+            'declaration',
+            {
+                allowArrowFunctions: true
+            }
+        ],
+        'eol-last': ERROR,
+        'space-infix-ops': ERROR,
+        'keyword-spacing': ERROR,
+        'space-before-blocks': ERROR,
+        'no-invalid-this': ERROR,
+        'consistent-this': ERROR,
+        'no-this-before-super': ERROR,
+        'no-unreachable': ERROR,
+        'no-sparse-arrays': ERROR,
+        'array-callback-return': ERROR,
+        'strict': [
+            WARN,
+            'global'
+        ],
+        'eqeqeq': ERROR,
+        'no-use-before-define': WARN,
+        'no-undef': ERROR,
+        'no-unused-vars': WARN,
+        'no-mixed-spaces-and-tabs': ERROR,
+        'operator-linebreak': [
+            ERROR,
+            'before'
+        ],
+        'no-console': [
+            OFF
+        ],
+        "mocha/no-exclusive-tests": "error"
+    }
+};

.jscsrc

@@ -1,3 +1,5 @@
+'use strict';
+
 const request = require('request-promise');
 const co = require('co');
 const csv = require('csv');
@@ -10,10 +12,7 @@ let signedUrl;
 let timeout;
 let rowCount = 0;
 
-exports.init = init;
-exports.process = processAction;
-
-function init(cfg) {
+exports.init = function init(cfg) {
     return co(function* gen() {
 
         const delimiter = cfg.reader.delimiter || ',';
@@ -40,11 +39,11 @@ function init(cfg) {
 
         stringifier.pipe(request.put(putUrl));
     });
-}
+};
 
-function processAction(msg, cfg) {
+exports.process = function ProcessAction(msg, cfg) {
+    // eslint-disable-next-line consistent-this
     const self = this;
-
     const startRow = cfg.reader.startRow || 0;
 
     if (startRow !== 0 && rowCount === 0) {
@@ -55,7 +54,7 @@ function processAction(msg, cfg) {
         clearTimeout(timeout);
     }
 
-    timeout = setTimeout(()=> {
+    timeout = setTimeout(() => {
         console.log('Closing the stream due to inactivity');
         co(function* gen() {
             const finalRowCount = rowCount - startRow;
@@ -67,30 +66,30 @@ function processAction(msg, cfg) {
             });
             const fileName = messageToEmit.id + '.csv';
             messageToEmit.attachments[fileName] = {
-                "content-type": "text/csv",
-                url: signedUrl.get_url
+                'content-type': 'text/csv',
+                'url': signedUrl.get_url
             };
             signedUrl = null;
             rowCount = 0;
 
             console.log('Emitting message %j', messageToEmit);
             self.emit('data', messageToEmit);
 
-            yield init(cfg);
+            yield exports.init(cfg);
         });
     }, 10000);
 
     if (startRow <= rowCount) {
         let row = msg.body;
-        if( cfg.reader.columns) {
+        if (cfg.reader.columns) {
             const columns = Object.keys(_.keyBy(cfg.reader.columns, 'property'));
             row = _.pick(msg.body, columns);
         }
         stringifier.write(row);
     }
     rowCount++;
     this.emit('end');
-}
+};
 
 /**