Open only one connection pool per one execution and reuse it (#71)

Author: if0s

.circleci/config.yml

@@ -19,7 +19,7 @@ jobs:
           command: ./gradlew test --daemon
       - run:
           name: Run Integration Tests
-          command: ./gradlew integrationTest --daemon
+          command: ./gradlew integrationTest --daemon --stacktrace
 workflows:
   version: 2
   build_and_test:

CHANGELOG.md

@@ -1,3 +1,6 @@
+## 2.4.5 (September 1, 2021)
+Open only one connection pool per one execution and reuse it
+
 ## 2.4.4 (August 12, 2021)
 * Remove dependencyCheckAnalyze task
 

build.gradle

@@ -1,5 +1,4 @@
 group = 'io.elastic'
-version = '2.4.4'
 apply plugin: 'java'
 apply plugin: 'idea'
 apply plugin: 'eclipse'

component.json

@@ -1,6 +1,7 @@
 {
   "title": "Database",
   "description": "Database JDBC connector",
+  "version": "2.4.5",
   "buildType": "docker",
   "credentials": {
     "verifier": "io.elastic.jdbc.JdbcCredentialsVerifier",

src/main/java/io/elastic/jdbc/actions/CustomQuery.java

@@ -36,7 +36,8 @@ public void execute(ExecutionParameters parameters) {
     LOGGER.info("Found dbEngine: '{}'", dbEngine);
 
     List<Message> messages = new ArrayList<>();
-    try (Connection connection = Utils.getConnection(configuration)) {
+    try {
+      Connection connection = Utils.getConnection(configuration);
       connection.setAutoCommit(false);
       try (Statement statement = connection.createStatement()) {
         boolean status = statement.execute(queryString);

src/main/java/io/elastic/jdbc/actions/DeleteRowByPrimaryKey.java

@@ -70,7 +70,8 @@ public void execute(ExecutionParameters parameters) {
     }
 
     if (primaryKeysCount == 1) {
-      try (Connection connection = Utils.getConnection(configuration)) {
+      try {
+        Connection connection = Utils.getConnection(configuration);
         LOGGER.info("Executing delete row by primary key action");
         boolean isOracle = dbEngine.equals(Engines.ORACLE.name().toLowerCase());
         Utils.columnTypes = Utils.getColumnTypes(connection, isOracle, tableName);

src/main/java/io/elastic/jdbc/actions/ExecuteStoredProcedure.java

@@ -17,13 +17,12 @@ public class ExecuteStoredProcedure implements Function {
   public void execute(ExecutionParameters parameters) {
     final JsonObject body = parameters.getMessage().getBody();
     final JsonObject configuration = parameters.getConfiguration();
-
-    try (Connection connection = Utils.getConnection(configuration)) {
+    try {
+      Connection connection = Utils.getConnection(configuration);
       QueryFactory queryFactory = new QueryFactory();
       Query query = queryFactory.getQuery(configuration.getString("dbEngine"));
 
       JsonObject result = query.callProcedure(connection, body, configuration);
-
       parameters.getEventEmitter()
           .emitData(new Message.Builder().body(result).build());
     } catch (SQLException e) {

src/main/java/io/elastic/jdbc/actions/InsertAction.java

@@ -29,7 +29,8 @@ public void execute(ExecutionParameters parameters) {
     final boolean isOracle = dbEngine.equals(Engines.ORACLE.name().toLowerCase());
     final String tableName = Utils.getTableName(configuration, isOracle);
     LOGGER.info("Found dbEngine: '{}'", dbEngine);
-    try (Connection connection = Utils.getConnection(configuration)) {
+    try {
+      Connection connection = Utils.getConnection(configuration);
       Utils.columnTypes = Utils.getColumnTypes(connection, isOracle, tableName);
       LOGGER.debug("Detected column types");
       LOGGER.info("Inserting values in the table");

src/main/java/io/elastic/jdbc/actions/LookupRowByPrimaryKey.java

@@ -74,7 +74,8 @@ public void execute(ExecutionParameters parameters) {
 
     if (primaryKeysCount == 1) {
 
-      try (Connection connection = Utils.getConnection(configuration)) {
+      try {
+        Connection connection = Utils.getConnection(configuration);
         LOGGER.info("Executing lookup row by primary key action");
         Utils.columnTypes = Utils.getColumnTypes(connection, isOracle, tableName);
         LOGGER.debug("Detected column types");

src/main/java/io/elastic/jdbc/actions/SelectAction.java

@@ -3,20 +3,22 @@
 import io.elastic.api.ExecutionParameters;
 import io.elastic.api.Message;
 import io.elastic.api.Function;
+import io.elastic.api.ShutdownParameters;
 import io.elastic.jdbc.query_builders.Query;
 import io.elastic.jdbc.utils.QueryFactory;
 import io.elastic.jdbc.utils.Utils;
 import java.sql.Connection;
 import java.sql.SQLException;
+import java.sql.Statement;
 import java.util.ArrayList;
 import javax.json.Json;
 import javax.json.JsonObject;
 import javax.json.JsonString;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-public class SelectAction implements Function {
 
+public class SelectAction implements Function {
   private static final Logger LOGGER = LoggerFactory.getLogger(SelectAction.class);
   private static final String SQL_QUERY_VALUE = "sqlQuery";
   private static final String PROPERTY_NULLABLE_RESULT = "nullableResult";
@@ -52,9 +54,8 @@ public void execute(ExecutionParameters parameters) {
       sqlQuery = Query.preProcessSelect(sqlQuery);
       LOGGER.debug("Got SQL Query");
       ArrayList<JsonObject> resultList;
-      try(Connection connection = Utils.getConnection(configuration)){
-        resultList = query.executeSelectQuery(connection, sqlQuery, body);
-      }
+      Connection connection = Utils.getConnection(configuration);
+      resultList = query.executeSelectQuery(connection, sqlQuery, body);
       for (int i = 0; i < resultList.size(); i++) {
         LOGGER.debug("Columns count: {} from {}", i + 1, resultList.size());
         LOGGER.info("Emitting data...");