Issue 23 incorrect required fields (#34)

* Add new insert Action

Author: Olha Virolainen

CHANGELOG.md

@@ -1,8 +1,33 @@
- ## 2.2.0 (August 28, 2019)
+# JDBC Component
+
+## 2.3.0 (September 25, 2019)
+ 
+* Add new action `Insert` 
+ 
+## 2.2.0 (August 28, 2019)
 
  * Add support `Configuration properties` for DB connection
  * Enable circleci
 
- ## 2.1.0 (July 30, 2019)
- 
- * Initial release which includes a bunch of previous unversioned releases
+## 2.1.0 (2019-07-22)
+
+* Add Execute stored procedure action
+
+## 2.0.1 (2019-06-24)
+
+* Fix error logging for generating metadata of `Select` action
+
+## 2.0.0 (2018-09-19)
+
+* Add Select trigger
+* Add Get rows polling trigger
+
+* Add Select action
+* Add Lookup by primary key action
+* Add Upsert by primary key action (for migration)
+* Add Delete by primary key action
+
+* Remove CreateOrUpdateRecord action
+
+* Fix issue in postgresql - getDate(null)
+* Fix null values as input for select

README.md

@@ -4,7 +4,7 @@
 This is an open source component for working with object-relational database management systems on [elastic.io platform](http://www.elastic.io "elastic.io platform").
 
 ### Completeness Matrix
-![JDBC Component Completeness Matrix](https://user-images.githubusercontent.com/5710732/55414696-e7c7bf80-556b-11e9-8aa9-bfe2ebca4303.png)
+![JDBC Component Completeness Matrix](https://user-images.githubusercontent.com/16806832/65326373-f6f20680-dbb9-11e9-9ad2-0900f68fd6e3.png)
 
 [JDBC Component Completeness Matrix](https://docs.google.com/spreadsheets/d/1sZr9ydJbMK8v-TguctmFDiqgjRKcrpbdj4CeFuZEkQU/edit?usp=sharing)
 
@@ -24,6 +24,9 @@ Following actions are inside:
 ``UPSERT BY PRIMARY KEY`` - this action will execute select command from specified table, as search criteria can be used only [PRIMARY KEY](https://en.wikipedia.org/wiki/Primary_key "PRIMARY KEY"), and execute insert command by PRIMARY KEY with specified field, if result does not found, else - action will execute update command by PRIMARY KEY with specified field. The action returns only one result row (a primary key is unique).
 
 ``DELETE BY PRIMARY KEY`` - this action will execute delete query from specified table, as criteria can be used only [PRIMARY KEY](https://en.wikipedia.org/wiki/Primary_key "PRIMARY KEY"). The action returns an integer value that indicates the number of rows affected, the returned value can be 0 or 1 (a primary key is unique).
+
+``INSERT`` - this action will execute insert query into the specified table. The action returns boolean value is execution insert successful or not.
+
 ### How works
 
 ### Requirements
@@ -168,38 +171,29 @@ Checkbox ``Don't throw Error on an Empty Result`` allows to emit an empty respon
 ![image](https://user-images.githubusercontent.com/40201204/43644579-f593d1c8-9737-11e8-9b97-ee9e575a19f7.png)
 As an input metadata you will get a Primary Key field to provide the data inside as a clause value.
 
-### Upsert Row By Primary Key action
-The action will execute ``SELECT`` command from a ``Tables`` dropdown field, as search criteria can be used only [PRIMARY KEY](https://en.wikipedia.org/wiki/Primary_key "PRIMARY KEY"), and execute ``INSERT`` command by PRIMARY KEY with specified field, if result does not found, else - action will execute ``UPDATE`` command by PRIMARY KEY with specified field. The action returns only one result row (a primary key is unique).
-1. Find and select jdbc-component in the component repository
-![image](https://user-images.githubusercontent.com/16806832/44981615-c70a9d80-af7b-11e8-8055-3b553abe8212.png)
-
-2. Create new or select existing credentials
-![image](https://user-images.githubusercontent.com/16806832/44981652-e86b8980-af7b-11e8-897e-04d1fc9a93cf.png)
-
-3. Select action "Upsert Row By Primary Key" from list
-![image](https://user-images.githubusercontent.com/16806832/44981700-0d5ffc80-af7c-11e8-9ac3-aedb16e1d788.png)
+### Insert action
+The action will execute ``INSERT`` command into the table from ``Table`` dropdown list the values specified in the body.
 
-4. Select table from ``Table`` dropdown list
-![image](https://user-images.githubusercontent.com/16806832/44981754-38e2e700-af7c-11e8-87d3-f029a7fec8fa.png)
+#### List of Expected Config fields
 
-5. Specify input data (field with red asterisk is Primary key), and click "Continue"
-![image](https://user-images.githubusercontent.com/16806832/44981854-83fcfa00-af7c-11e8-9ef2-8c06e77fed1e.png)
+#### Input fields description
+##### Table
 
-6. Retrieving sample
-![image](https://user-images.githubusercontent.com/16806832/44983059-86f9e980-af80-11e8-8178-77e463488c7a.png)
+Action contains only one configuration field `Table` - dropdown list with available table names.
+![image](https://user-images.githubusercontent.com/16806832/65327293-3f122880-dbbc-11e9-8a07-a10131900962.png)
 
-7. Retrieve sample result
-![image](https://user-images.githubusercontent.com/16806832/44982952-2ec2e780-af80-11e8-98b1-58c3adbc15b9.png)
+#### Expected input metadata
 
-8. Click "Continue"
-![image](https://user-images.githubusercontent.com/16806832/44983101-b0b31080-af80-11e8-82d8-0e70e4b4ff97.png)
+As input metadata, you will get all fields of the selected table except for fields with `auto-increment` or `auto-calculated` property. 
 
-9. Finish component configuration
-![image](https://user-images.githubusercontent.com/16806832/44983365-90378600-af81-11e8-9be4-4dbb39af0fdc.png)
+#### Expected output metadata
 
-#### Input fields description
-As an input metadata you will get all fields of selected table. [PRIMARY KEY](https://en.wikipedia.org/wiki/Primary_key "PRIMARY KEY") is required field (will mark as asterisk) and other input fields are optional.
-![image](https://user-images.githubusercontent.com/16806832/44397461-1a76f780-a549-11e8-8247-9a6f9aa3f3b4.png)
+As output metadata, you will get execution insert result like:
+```json
+{
+  "result": true
+}
+```
 
 ### Delete Row By Primary Key action
 ![image](https://user-images.githubusercontent.com/40201204/43592505-5b6bbfe8-967e-11e8-845e-2ce8ac707357.png)
@@ -249,6 +243,39 @@ Component generates next metadata:
 
 ![image](https://user-images.githubusercontent.com/22715422/62056735-edd26200-b226-11e9-871e-0efc305d70b2.png)
 
+### Upsert Row By Primary Key action
+The action will execute ``SELECT`` command from a ``Tables`` dropdown field, as search criteria can be used only [PRIMARY KEY](https://en.wikipedia.org/wiki/Primary_key "PRIMARY KEY"), and execute ``INSERT`` command by PRIMARY KEY with specified field, if result does not found, else - action will execute ``UPDATE`` command by PRIMARY KEY with specified field. The action returns only one result row (a primary key is unique).
+1. Find and select jdbc-component in the component repository
+![image](https://user-images.githubusercontent.com/16806832/44981615-c70a9d80-af7b-11e8-8055-3b553abe8212.png)
+
+2. Create new or select existing credentials
+![image](https://user-images.githubusercontent.com/16806832/44981652-e86b8980-af7b-11e8-897e-04d1fc9a93cf.png)
+
+3. Select action "Upsert Row By Primary Key" from list
+![image](https://user-images.githubusercontent.com/16806832/44981700-0d5ffc80-af7c-11e8-9ac3-aedb16e1d788.png)
+
+4. Select table from ``Table`` dropdown list
+![image](https://user-images.githubusercontent.com/16806832/44981754-38e2e700-af7c-11e8-87d3-f029a7fec8fa.png)
+
+5. Specify input data (field with red asterisk is Primary key), and click "Continue"
+![image](https://user-images.githubusercontent.com/16806832/44981854-83fcfa00-af7c-11e8-9ef2-8c06e77fed1e.png)
+
+6. Retrieving sample
+![image](https://user-images.githubusercontent.com/16806832/44983059-86f9e980-af80-11e8-8178-77e463488c7a.png)
+
+7. Retrieve sample result
+![image](https://user-images.githubusercontent.com/16806832/44982952-2ec2e780-af80-11e8-98b1-58c3adbc15b9.png)
+
+8. Click "Continue"
+![image](https://user-images.githubusercontent.com/16806832/44983101-b0b31080-af80-11e8-82d8-0e70e4b4ff97.png)
+
+9. Finish component configuration
+![image](https://user-images.githubusercontent.com/16806832/44983365-90378600-af81-11e8-9be4-4dbb39af0fdc.png)
+
+#### Input fields description
+As an input metadata you will get all fields of selected table. [PRIMARY KEY](https://en.wikipedia.org/wiki/Primary_key "PRIMARY KEY") is required field (will mark as asterisk) and other input fields are optional.
+![image](https://user-images.githubusercontent.com/16806832/44397461-1a76f780-a549-11e8-8247-9a6f9aa3f3b4.png)
+
 
 ### Create or update record action (Deprecated)
 This action exists in JDBC component only for backward compatibility. 

build.gradle

@@ -1,5 +1,5 @@
 group = 'io.elastic'
-version = '2.2.0'
+version = '2.3.0'
 apply plugin: 'java'
 apply plugin: 'idea'
 apply plugin: 'eclipse'

changelog.md

@@ -66,13 +66,13 @@
           "prompt": "Select a Table",
           "label": "Tables List",
           "required": true,
-          "model": "io.elastic.jdbc.TableNameProvider"
+          "model": "io.elastic.jdbc.providers.TableNameProvider"
         },
         "pollingField": {
           "viewClass": "SelectView",
           "prompt": "Select a Timestamp (or similar) Column",
           "label": "Timestamp (or similar) Column",
-          "model": "io.elastic.jdbc.ColumnNamesProvider",
+          "model": "io.elastic.jdbc.providers.ColumnNamesProvider",
           "required": true,
           "require": [
             "tableName"
@@ -85,7 +85,7 @@
           "placeholder": "1970-01-01 00:00:00.000"
         }
       },
-      "dynamicMetadata": "io.elastic.jdbc.ColumnNamesProvider"
+      "dynamicMetadata": "io.elastic.jdbc.providers.ColumnNamesProvider"
     },
     "selectTrigger": {
       "main": "io.elastic.jdbc.triggers.SelectTrigger",
@@ -107,7 +107,7 @@
           "placeholder": "1970-01-01 00:00:00.000"
         }
       },
-      "dynamicMetadata": "io.elastic.jdbc.ColumnNamesProvider"
+      "dynamicMetadata": "io.elastic.jdbc.providers.ColumnNamesProvider"
     },
     "select": {
       "main": "io.elastic.jdbc.triggers.SelectTriggerOld",
@@ -121,20 +121,20 @@
           "prompt": "Select a Table",
           "label": "Tables List",
           "required": true,
-          "model": "io.elastic.jdbc.TableNameProviderOld"
+          "model": "io.elastic.jdbc.providers.TableNameProviderOld"
         },
         "orderField": {
           "viewClass": "SelectView",
           "prompt": "Select a field to order rows",
           "label": "Order Column",
-          "model": "io.elastic.jdbc.ColumnNamesProviderOld",
+          "model": "io.elastic.jdbc.providers.ColumnNamesProviderOld",
           "required": true,
           "require": [
             "tableName"
           ]
         }
       },
-      "dynamicMetadata": "io.elastic.jdbc.ColumnNamesProviderOld"
+      "dynamicMetadata": "io.elastic.jdbc.providers.ColumnNamesProviderOld"
     }
   },
   "actions": {
@@ -148,17 +148,17 @@
           "prompt": "Select a Table",
           "label": "Table",
           "required": true,
-          "model": "io.elastic.jdbc.TableNameProvider"
+          "model": "io.elastic.jdbc.providers.TableNameProvider"
         },
         "nullableResult": {
           "label": "Don`t throw Error on an Empty Result",
           "viewClass": "CheckBoxView"
         }
       },
-      "dynamicMetadata": "io.elastic.jdbc.PrimaryColumnNamesProvider"
+      "dynamicMetadata": "io.elastic.jdbc.providers.PrimaryColumnNamesProvider"
     },
     "upsertRowByPrimaryKey": {
-      "main": "io.elastic.jdbc.actions.UpsertRowByPrimaryKey",
+      "main": "io.elastic.jdbc.actions.providers.UpsertRowByPrimaryKey",
       "title": "Upsert Row By Primary Key",
       "description": "Executes upsert by primary key",
       "fields": {
@@ -167,10 +167,25 @@
           "prompt": "Select a Table",
           "label": "Table",
           "required": true,
-          "model": "io.elastic.jdbc.TableNameProvider"
+          "model": "io.elastic.jdbc.providers.TableNameProvider"
         }
       },
-      "dynamicMetadata": "io.elastic.jdbc.ColumnNamesWithPrimaryKeyProvider"
+      "dynamicMetadata": "io.elastic.jdbc.providers.ColumnNamesWithPrimaryKeyProvider"
+    },
+    "insert": {
+      "main": "io.elastic.jdbc.actions.InsertAction",
+      "title": "Insert",
+      "description": "Executes insert value",
+      "fields": {
+        "tableName": {
+          "viewClass": "SelectView",
+          "prompt": "Select a Table",
+          "label": "Table",
+          "required": true,
+          "model": "io.elastic.jdbc.providers.TableNameProvider"
+        }
+      },
+      "dynamicMetadata": "io.elastic.jdbc.providers.ColumnNamesForInsertProvider"
     },
     "deleteRowByPrimaryKey": {
       "main": "io.elastic.jdbc.actions.DeleteRowByPrimaryKey",
@@ -182,14 +197,14 @@
           "prompt": "Select a Table",
           "label": "Tables",
           "required": true,
-          "model": "io.elastic.jdbc.TableNameProvider"
+          "model": "io.elastic.jdbc.providers.TableNameProvider"
         },
         "nullableResult": {
           "label": "Don`t throw Error on an Empty Result",
           "viewClass": "CheckBoxView"
         }
       },
-      "dynamicMetadata": "io.elastic.jdbc.PrimaryColumnNamesProvider"
+      "dynamicMetadata": "io.elastic.jdbc.providers.PrimaryColumnNamesProvider"
     },
     "selectAction": {
       "main": "io.elastic.jdbc.actions.SelectAction",
@@ -208,7 +223,7 @@
           "viewClass": "CheckBoxView"
         }
       },
-      "dynamicMetadata": "io.elastic.jdbc.QueryColumnNamesProvider"
+      "dynamicMetadata": "io.elastic.jdbc.providers.QueryColumnNamesProvider"
     },
     "createOrUpdateRecord": {
       "main": "io.elastic.jdbc.actions.CreateOrUpdateRecord",
@@ -221,20 +236,20 @@
           "prompt": "Select a Table",
           "label": "Tables",
           "required": true,
-          "model": "io.elastic.jdbc.TableNameProviderOld"
+          "model": "io.elastic.jdbc.providers.TableNameProviderOld"
         },
         "idColumn": {
           "viewClass": "SelectView",
           "prompt": "Select an ID column",
           "label": "ID Column",
-          "model": "io.elastic.jdbc.ColumnNamesProviderOld",
+          "model": "io.elastic.jdbc.providers.ColumnNamesProviderOld",
           "required": true,
           "require": [
             "tableName"
           ]
         }
       },
-      "dynamicMetadata": "io.elastic.jdbc.ColumnNamesProviderOld"
+      "dynamicMetadata": "io.elastic.jdbc.providers.ColumnNamesProviderOld"
     },
     "executeStoredProcedure": {
       "main": "io.elastic.jdbc.actions.ExecuteStoredProcedure",
@@ -246,20 +261,20 @@
           "prompt": "Select a Schema",
           "label": "DB Schema",
           "required": true,
-          "model": "io.elastic.jdbc.SchemasProvider"
+          "model": "io.elastic.jdbc.providers.SchemasProvider"
         },
         "procedureName": {
           "viewClass": "SelectView",
           "prompt": "Select a stored procedure name",
           "label": "Stored procedure",
-          "model": "io.elastic.jdbc.ProcedureFieldsNameProvider",
+          "model": "io.elastic.jdbc.providers.ProcedureFieldsNameProvider",
           "required": true,
           "require": [
             "schemaName"
           ]
         }
       },
-      "dynamicMetadata": "io.elastic.jdbc.ProcedureFieldsNameProvider"
+      "dynamicMetadata": "io.elastic.jdbc.providers.ProcedureFieldsNameProvider"
     }
   }
 }

component.json

@@ -2,6 +2,7 @@
 
 import io.elastic.api.CredentialsVerifier;
 import io.elastic.api.InvalidCredentialsException;
+import io.elastic.jdbc.utils.Utils;
 import java.sql.Connection;
 import java.sql.SQLException;
 import javax.json.JsonObject;

src/main/java/io/elastic/jdbc/JdbcCredentialsVerifier.java

@@ -5,9 +5,9 @@
 import io.elastic.api.ExecutionParameters;
 import io.elastic.api.Message;
 import io.elastic.api.Module;
-import io.elastic.jdbc.EnginesOld;
-import io.elastic.jdbc.SailorVersionsAdapter;
-import io.elastic.jdbc.UtilsOld;
+import io.elastic.jdbc.utils.EnginesOld;
+import io.elastic.jdbc.utils.SailorVersionsAdapter;
+import io.elastic.jdbc.utils.UtilsOld;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;