Fixed ESLINT warnings, migrated to salior 2.0 and now using promises in trigger

Author: zubairov

lib/actions/createEvent.js

@@ -1,3 +1,4 @@
+/*eslint no-console: 0 consistent-this: 0*/
 'use strict';
 const elasticio = require('elasticio-node');
 const messages = elasticio.messages;
@@ -21,14 +22,13 @@ function getCalendars(cfg, cb) {
     console.log('Getting calendar data ...');
     const instance = new ApiClient(cfg);
     return instance
-    .get('/me/calendars')
-    .then(processData)
-    .nodeify(cb);
+        .get('/me/calendars')
+        .then(processData)
+        .nodeify(cb);
 }
 
 
 function processAction(msg, cfg) {
-
     const self = this;
     const calendarId = cfg.calendarId;
     console.log(`About to create event in calendar with id=${calendarId}`);
@@ -65,9 +65,9 @@ function processAction(msg, cfg) {
 
 
     let promise = processEventData(cfg, msg.body)
-    .then(createEvent)
-    .then(emitData)
-    .fail(emitError);
+        .then(createEvent)
+        .then(emitData)
+        .fail(emitError);
 
     return promise.finally(emitEnd);
 

lib/processEventDataHelper.js

@@ -1,3 +1,4 @@
+/*eslint no-console: 0 */
 'use strict';
 const moment = require('moment-timezone');
 const _ = require('lodash');

lib/triggers/contacts.js

@@ -1,26 +1,25 @@
-/* eslint new-cap: [2, {"capIsNewExceptions": ["Q"]}] */
+/* eslint no-console: 0 no-invalid-this: 0*/
 'use strict';
 const messages = require('elasticio-node').messages;
 const co = require('co');
 const MicrosoftGraph = require('msgraph-sdk-javascript');
 const rp = require('request-promise');
 
-module.exports.process = processAction;
-
 /**
  * This method will be called from elastic.io platform providing following data
  *
  * @param msg incoming message object that contains ``body`` with payload
  * @param cfg configuration that is account information and configuration field values
+ * @param snapshot - snapshot that stores the data between the runs
  */
 function processAction(msg, cfg, snapshot) {
     console.log('Snapshot is %j', snapshot);
 
-  // Should be in ISO-Date format
+    // Should be in ISO-Date format
     snapshot.lastModifiedDateTime = snapshot.lastModifiedDateTime || new Date(0).toISOString();
 
-  // Main loop
-    co(function* mainLoop() {
+    // Main loop
+    return co(function* mainLoop() {
         console.log('Refreshing an OAuth Token');
         const newToken = yield rp({
             method: 'POST',
@@ -49,11 +48,11 @@ function processAction(msg, cfg, snapshot) {
 
         console.log('Selecting contacts that was modified since %s', snapshot.lastModifiedDateTime);
         const contacts = yield client
-      .api('/me/contacts')
-      .orderby('lastModifiedDateTime asc')
-      .top(900)
-      .filter('lastModifiedDateTime gt ' + snapshot.lastModifiedDateTime)
-      .get();
+            .api('/me/contacts')
+            .orderby('lastModifiedDateTime asc')
+            .top(900)
+            .filter('lastModifiedDateTime gt ' + snapshot.lastModifiedDateTime)
+            .get();
         const values = contacts.value;
         console.log('Found %s contacts', values.length);
         if (values.length > 0) {
@@ -62,20 +61,17 @@ function processAction(msg, cfg, snapshot) {
             });
             this.emit('data', message);
             let lmdate = new Date(values[values.length - 1].lastModifiedDateTime);
-      // The output value has always 0 milliseconds
-      // we need to set the milliseconds value to 999 in order not to see
-      // the duplicate results
+            // The output value has always 0 milliseconds
+            // we need to set the milliseconds value to 999 in order not to see
+            // the duplicate results
             lmdate.setMilliseconds(999);
             snapshot.lastModifiedDateTime = lmdate.toISOString();
         } else {
             console.log('No contacts modified since %s were found', snapshot.lastModifiedDateTime);
         }
         console.log('Processing completed, new lastModifiedDateTime is ' + snapshot.lastModifiedDateTime);
         this.emit('snapshot', snapshot);
-        this.emit('end');
-    }.bind(this)).catch(err => {
-        console.log('Error occured', err.stack || err);
-        this.emit('error', err);
-        this.emit('end');
-    });
+    }.bind(this));
 }
+
+module.exports.process = processAction;

package.json

@@ -27,7 +27,7 @@
     "bluebird": "^3.4.6",
     "co": "^4.6.0",
     "elasticio-node": "0.0.7",
-    "elasticio-sailor-nodejs": "1.3.0",
+    "elasticio-sailor-nodejs": "2.0.0",
     "lodash": "^4.17.2",
     "moment": "^2.1.16",
     "moment-timezone": "^0.5.9",

spec/helpers/checkRequiredFields.spec.js

@@ -1,10 +1,8 @@
 'use strict';
-const moment = require('moment');
 
 describe('Outlook Check Required Fields', function test() {
 
     const action = require('../../lib/processEventDataHelper');
-    const data = require('../data/processEventData_test.json');
 
     it('throws an error when required cfg field calendarId is missing', function test() {
         let configInput = {

spec/helpers/formatDate.spec.js

@@ -1,10 +1,8 @@
 'use strict';
-const moment = require('moment');
 
 describe('Outlook Format Date', function test() {
 
     const action = require('../../lib/processEventDataHelper');
-    const data = require('../data/processEventData_test.json');
 
   //Check if the date FORMAT itself is as expected.
     describe('formats input date string based on given parameter ', function test() {