Stabilize the current #[builder(getter)] feature MVP

Author: Veetaha

.github/workflows/ci.yml

@@ -112,19 +112,19 @@ jobs:
       - run: cargo test --locked --all-features --doc
       - run: |
           cd bon && cargo test --locked --no-default-features \
-            --features=experimental-overwritable,experimental-getter
+            --features=experimental-overwritable
 
       - run: |
           cd bon && cargo test --locked --no-default-features \
-            --features=experimental-overwritable,experimental-getter,alloc
+            --features=experimental-overwritable,alloc
 
       - run: |
           cd bon && cargo test --locked --no-default-features \
-            --features=experimental-overwritable,experimental-getter,implied-bounds
+            --features=experimental-overwritable,implied-bounds
 
       - run: |
           cd bon && cargo test --locked --no-default-features \
-            --features=experimental-overwritable,experimental-getter,alloc,implied-bounds
+            --features=experimental-overwritable,alloc,implied-bounds
 
   test-msrv:
     runs-on: ${{ matrix.os }}-latest

bon-macros/Cargo.toml

@@ -63,9 +63,6 @@ rustversion  = "1.0"
 [features]
 default = []
 
-# See the docs on this feature in the `bon`'s crate `Cargo.toml`.
-experimental-getter = []
-
 # See the docs on this feature in the `bon`'s crate `Cargo.toml`
 experimental-overwritable = []
 

bon-macros/src/builder/builder_gen/member/config/mod.rs

@@ -223,18 +223,6 @@ impl MemberConfig {
         }
 
         if let Some(getter) = &self.getter {
-            if !cfg!(feature = "experimental-getter") {
-                bail!(
-                    &getter.key,
-                    "🔬 `getter` attribute is experimental and requires \
-                    \"experimental-getter\" cargo feature to be enabled; \
-                    if you find the current design of this attribute already \
-                    solid please leave a 👍 reaction under the issue \
-                    https://github.com/elastio/bon/issues/225; if you have \
-                    any feedback, then feel free to leave a comment under that issue",
-                );
-            }
-
             self.validate_mutually_exclusive(
                 ParamName::Getter,
                 getter.key.span(),

bon-sandbox/Cargo.toml

@@ -34,6 +34,6 @@ derive_builder = "0.20"
 typed-builder  = "0.20"
 
 [dependencies.bon]
-features = ["experimental-overwritable", "experimental-getter"]
+features = ["experimental-overwritable"]
 path     = "../bon"
 version  = "=3.3.2"

bon/Cargo.toml

@@ -83,15 +83,9 @@ implied-bounds = ["bon-macros/implied-bounds"]
 # describing your use case for it.
 experimental-overwritable = ["bon-macros/experimental-overwritable"]
 
-# 🔬 Experimental! There may be breaking changes to this feature between *minor* releases,
-# however, compatibility within patch releases is guaranteed though.
-#
-# This feature enables the #[builder(getter)] attribute that can be used to
-# allow getting references to already set fields in the builder.
-#
-# See more info at https://bon-rs.com/reference/builder/member/getter.
+# Legacy experimental attribute. It's left here for backwards compatibility,
+# and it will be removed in the next major release.
 #
-# The fate of this feature depends on your feedback in the tracking issue
-# https://github.com/elastio/bon/issues/225. Please, let us know if you
-# have any ideas how to make this attribute better, or if it's already good enough!
-experimental-getter = ["bon-macros/experimental-getter"]
+# We've stabilized the MVP of this feature, so it's no longer experimental.
+# The tracking issue for this feature: https://github.com/elastio/bon/issues/225.
+experimental-getter = []

scripts/test-msrv.sh

@@ -40,7 +40,7 @@ step cargo update -p libc --precise 0.2.163
 
 export RUSTFLAGS="${RUSTFLAGS:-} --allow unknown-lints"
 
-features=experimental-overwritable,experimental-getter
+features=experimental-overwritable
 
 step cargo clippy --all-targets --locked --features "$features"
 

website/src/reference/builder/member/getter.md

@@ -1,16 +1,12 @@
-# `getter` :microscope:
+# `getter`
 
 **Applies to:** <Badge type="warning" text="struct fields"/> <Badge type="warning" text="function arguments"/> <Badge type="warning" text="method arguments"/>
 
 Generates a getter method for a member. The method is callable only after the value for the member is set using any of its setters.
 
-::: danger 🔬 **Experimental**
+> This attribute has some planned future extensions described in the tracking issue [#225](https://github.com/elastio/bon/issues/225). Any feedback is appreciated!
 
-This attribute is available under the cargo feature `experimental-getter`. Breaking changes may occur between **minor** releases but not between patch releases.
-
-The fate of this feature depends on your feedback in the tracking issue [#225](https://github.com/elastio/bon/issues/225). Please, let us know if you have any ideas on improving this attribute, or if it's already good enough!
-
-:::
+---
 
 The getter for a required member returns `&T` by default (can be [overridden](#overriding-the-return-type)).
 
@@ -119,7 +115,7 @@ You can override the return type of the getter, its name, visibility, and docs.
         deref,
 
         // Return the type specified in parens.
-        // A deref coercion is expected to be valid to the specified type.
+        // There must exist a deref coercion is to the specified type.
         // Don't specify the leading `&` here.
         deref(T),