Add pre-commit hook for migration scripts

Author: elastisys-staffan

.pre-commit-config.yaml

@@ -97,6 +97,14 @@ repos:
         require_serial: true
         entry: tests/common/check-js.bash
 
+      - id: avoid-direct-cli-tools
+        name: Avoid direct use of kubectl, helmfile, and helm in migrations (excluding comments, helpers, paths, logs, and strings)
+        entry: >-
+          (?m)^(?!\s*#)(?!.*log_(info|warn|error|fatal)\s+["']).*(?:^|\s)(?<!/)(kubectl(?![_a-zA-Z])|helmfile(?![_a-zA-Z])|helm(?![_a-zA-Z]))(?=\s|$)
+        language: pygrep
+        types: [text]
+        files: '^migration/[^/]+/[^/]+/[^/]+\.sh$'
+
   - repo: https://github.com/codespell-project/codespell
     rev: v2.3.0
     hooks:

migration/v0.46/apply/20-kube-prometheus-stack.sh

@@ -12,11 +12,6 @@ if [[ -z "${CK8S_CLUSTER:-}" ]]; then
   log_fatal "CK8S_CLUSTER is not set. Please export CK8S_CLUSTER=wc|sc|both before running."
 fi
 
-# Check if helmfile exists
-if ! command -v helmfile >/dev/null 2>&1; then
-  log_fatal "helmfile is not installed. Please install it before running."
-fi
-
 run() {
   case "${1:-}" in
   execute)