push error handling

Author: alexanderkirtzel

packages/sources/node/src/index.ts

@@ -1,5 +1,4 @@
 import type { Elb, SourceNode } from './types';
-import { handleCommand, handleEvent } from './lib/handle';
 import { run } from './lib/run';
 import { getState } from './lib/state';
 import { createPush } from './lib/push';
@@ -26,7 +25,7 @@ export function sourceNode(
   };
 
   // Overwrite the push function with the instance-reference
-  instance.push = createPush(instance, handleCommand, handleEvent);
+  instance.push = createPush(instance);
 
   // That's when the party starts
   run(instance);

packages/sources/node/src/lib/push.ts

@@ -10,12 +10,9 @@ import {
 } from '@elbwalker/utils';
 import { isCommand } from './helper';
 import { destinationInit, destinationPush } from './destination';
+import { handleCommand, handleEvent } from './handle';
 
-export function createPush(
-  instance: SourceNode.Instance,
-  handleCommand: SourceNode.HandleCommand,
-  handleEvent: SourceNode.HandleEvent,
-): Elb.Fn {
+export function createPush(instance: SourceNode.Instance): Elb.Fn {
   const push = async (
     nameOrEvent: unknown,
     data: Elb.PushData = {},

packages/sources/walkerjs/src/lib/push.ts

@@ -28,23 +28,37 @@ export function createPush(instance: SourceWalkerjs.Instance): Elb.Fn {
     nested: WalkerOS.Entities = [],
     custom: WalkerOS.Properties = {},
   ) => {
-    const { event, command } = createEventOrCommand(
-      instance,
-      nameOrEvent,
-      pushData,
-      pushContext,
-      nested,
-      custom,
-      options,
-    );
-
-    if (command) {
-      // Command event
-      handleCommand(instance, command, pushData, options);
-    } else if (event) {
-      // Regular event
-      handleEvent(instance, event);
-    }
+    return tryCatch(
+      (
+        nameOrEvent: unknown,
+        pushData: Elb.PushData,
+        options: Elb.PushOptions,
+        pushContext: Elb.PushContext,
+        nested: WalkerOS.Entities,
+        custom: WalkerOS.Properties,
+      ) => {
+        const { event, command } = createEventOrCommand(
+          instance,
+          nameOrEvent,
+          pushData,
+          pushContext,
+          nested,
+          custom,
+          options,
+        );
+
+        if (command) {
+          // Command event
+          handleCommand(instance, command, pushData, options);
+        } else if (event) {
+          // Regular event
+          handleEvent(instance, event);
+        }
+      },
+      () => {
+        // @TODO custom error handling
+      },
+    )(nameOrEvent, pushData, options, pushContext, nested, custom);
   };
 
   return useHooks(push, 'Push', instance.hooks);