Skip to content

Commit 537223e

Browse files
event as Value
1 parent 83be54c commit 537223e

File tree

3 files changed

+8
-13
lines changed

3 files changed

+8
-13
lines changed

packages/connectors/datalayer/src/__tests__/mapping.test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ describe('mapping', () => {
161161
elb,
162162
mapping: {
163163
foo: {
164-
event: 'entity action',
164+
event: { value: 'entity action' },
165165
data: {
166166
some: {
167167
value: 'thing',
@@ -238,7 +238,7 @@ describe('mapping', () => {
238238
elb,
239239
mapping: {
240240
add_to_cart: {
241-
event: 'product add',
241+
event: { value: 'product add' },
242242
data: {
243243
id: 'items.0.item_id',
244244
name: 'items.0.item_name',
@@ -287,7 +287,7 @@ describe('mapping', () => {
287287
elb,
288288
mapping: {
289289
purchase: {
290-
event: 'order complete',
290+
event: { value: 'order complete' },
291291
data: {
292292
id: 'transaction_id',
293293
currency: 'currency',

packages/connectors/datalayer/src/mapping.ts

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,13 +25,9 @@ export function objToEvent(
2525
data: obj as WalkerOS.Properties,
2626
};
2727

28-
// event name
29-
let eventName = `${config.prefix} ${obj.event.replace(/ /g, '_')}`;
30-
3128
if (mapping) {
32-
if (mapping.event) eventName = mapping.event;
33-
3429
const eventMappingValueKeys: Array<keyof EventMappingValues> = [
30+
'event',
3531
'id',
3632
'trigger',
3733
'entity',
@@ -111,7 +107,8 @@ export function objToEvent(
111107
}
112108

113109
// Update the event name
114-
event.event = eventName;
110+
event.event =
111+
event.event || `${config.prefix} ${obj.event.replace(/ /g, '_')}`;
115112

116113
// source type is dataLayer
117114
event.source = event.source ?? {};

packages/connectors/datalayer/src/types/index.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,7 @@ export interface Mapping {
2020
[event: string]: EventMapping;
2121
}
2222

23-
export type EventMapping = EventMappingValues &
24-
EventMappingObjectValues & {
25-
event?: string;
26-
};
23+
export type EventMapping = EventMappingValues & EventMappingObjectValues;
2724

2825
export type EventMappingObjectValues = {
2926
data?: ObjectValue;
@@ -38,6 +35,7 @@ export type EventMappingObjectValues = {
3835
};
3936

4037
export type EventMappingValues = {
38+
event?: Value;
4139
id?: Value;
4240
trigger?: Value;
4341
entity?: Value;

0 commit comments

Comments
 (0)