prevent duplicate checks on same run

Author: alexanderkirtzel

packages/sources/walkerjs/src/__tests__/session.test.ts

@@ -1,7 +1,7 @@
-import { Walkerjs } from '..';
+import type { SourceWalkerjs } from '..';
+import { elb, Walkerjs } from '..';
 import { mockDataLayer } from '@elbwalker/jest/web.setup';
 import { sessionStart } from '@elbwalker/utils/web';
-import type { SourceWalkerjs } from '..';
 
 jest.mock('@elbwalker/utils/web', () => {
   const utilsOrg = jest.requireActual('@elbwalker/utils/web');
@@ -78,4 +78,33 @@ describe('Session', () => {
 
     expect(mockFn).toHaveBeenCalledTimes(2);
   });
+
+  test('multiple consent updates', () => {
+    const originalLocation = window.location;
+    Object.defineProperty(window, 'location', {
+      value: new URL('https://www.elbwalker.com/?utm_campaign=foo'),
+    });
+
+    walkerjs = Walkerjs({
+      default: true,
+      session: { consent: 'marketing', storage: true },
+      pageview: false,
+    });
+
+    expect(mockDataLayer).toHaveBeenCalledTimes(0);
+    elb('walker consent', { marketing: true });
+    elb('walker consent', { marketing: true });
+
+    expect(mockDataLayer).toHaveBeenCalledTimes(1);
+    expect(mockDataLayer).toHaveBeenCalledWith(
+      expect.objectContaining({
+        event: 'session start',
+        data: expect.any(Object),
+      }),
+    );
+
+    Object.defineProperty(window, 'location', {
+      value: originalLocation,
+    });
+  });
 });

packages/sources/walkerjs/src/lib/session.ts

@@ -26,19 +26,28 @@ export function sessionStart(
   const sessionConfig = assign(instance.config.session || {}, options.config);
   const sessionData = assign(instance.config.sessionStatic, options.data);
 
+  // Track the last processed group to prevent duplicate processing
+  let lastProcessedGroup: string;
+
   // A wrapper for the callback
   const cb: SessionCallback = (session, instance, defaultCb) => {
+    // Skip if we've already processed this group
+    if (instance && instance.group === lastProcessedGroup) return;
+
     let result: void | undefined | WalkerOS.SessionData;
     if (sessionConfig.cb !== false)
       // Run either the default callback or the provided one
       result = (sessionConfig.cb || defaultCb)(session, instance, defaultCb);
 
     if (isSameType(instance, {} as SourceWalkerjs.Instance)) {
+      // Remember this group has been processed
+      lastProcessedGroup = instance.group;
+
       // Assign the session
       instance.session = session;
 
       // Run on session events
-      onApply(instance as SourceWalkerjs.Instance, 'session');
+      onApply(instance, 'session');
     }
 
     return result;