async handling

Author: alexanderkirtzel

packages/destinations/web/google-ads/src/index.test.ts

@@ -34,7 +34,7 @@ describe('destination Google Ads', () => {
 
   afterEach(() => {});
 
-  test('init', () => {
+  test('init', async () => {
     (w.dataLayer as unknown) = undefined;
     (w.gtag as unknown) = undefined;
 
@@ -46,7 +46,7 @@ describe('destination Google Ads', () => {
     expect(w.dataLayer).not.toBeDefined();
     expect(w.gtag).not.toBeDefined();
 
-    elb(event);
+    await elb(event);
     expect(w.dataLayer).toBeDefined();
     expect(w.gtag).toBeDefined();
   });
@@ -64,15 +64,15 @@ describe('destination Google Ads', () => {
     expect(fn).toHaveBeenCalledTimes(3);
   });
 
-  test('Init calls', () => {
+  test('Init calls', async () => {
     elb('walker destination', destination);
 
-    elb(event);
+    await elb(event);
 
     expect(mockFn).toHaveBeenNthCalledWith(1, 'config', conversionId);
   });
 
-  test('init with load script', () => {
+  test('init with load script', async () => {
     destination.config.loadScript = true;
     elb('walker destination', destination);
 
@@ -81,7 +81,7 @@ describe('destination Google Ads', () => {
     let elem = document.querySelector(scriptSelector);
     expect(elem).not.toBeTruthy();
 
-    elb(event);
+    await elb(event);
 
     elem = document.querySelector(scriptSelector);
     expect(elem).toBeTruthy();

packages/destinations/web/piwikpro/src/index.test.ts

@@ -85,23 +85,23 @@ describe('Destination PiwikPro', () => {
     expect(mockFn).toHaveBeenCalledWith(...events.ecommerceAddToCart());
   });
 
-  test('event ecommerceProductDetailView', () => {
+  test('event ecommerceProductDetailView', async () => {
     const event = getEvent('product view');
     elb('walker destination', destination, {
       custom,
       mapping: mapping.config,
     });
-    elb(event);
+    await elb(event);
     expect(mockFn).toHaveBeenCalledWith(...events.ecommerceProductDetailView());
   });
 
-  test('event ecommerceCartUpdate', () => {
+  test('event ecommerceCartUpdate', async () => {
     const event = getEvent('cart view');
     elb('walker destination', destination, {
       custom,
       mapping: mapping.config,
     });
-    elb(event);
+    await elb(event);
     expect(mockFn).toHaveBeenCalledWith(...events.ecommerceCartUpdate());
   });
 });

packages/destinations/web/piwikpro/src/index.ts

@@ -36,14 +36,14 @@ export const destinationPiwikPro: Destination = {
     if (custom.linkTracking !== false) func(['enableLinkTracking']);
   },
 
-  push(event, config, mapping = {}, options = {}) {
+  async push(event, config, mapping = {}, options = {}) {
     const { fn } = config;
     const { data } = options;
     const func = fn || window._paq!.push;
 
     // Send pageviews if not disabled
     if (event.event === 'page view' && !mapping.custom) {
-      func(['trackPageView', getMappingValue(event, 'data.title')]);
+      func(['trackPageView', await getMappingValue(event, 'data.title')]);
       return;
     }