Squashed commit of the following:

commit b7ff238
Author: Karin Borm <k.borm@ostfalia.de>
Date:   Thu Nov 14 17:46:36 2024 +0100

    no handling for cbm behaviours

commit d54a4e6
Author: Karin Borm <k.borm@ostfalia.de>
Date:   Tue Nov 12 13:36:09 2024 +0100

    new deferred behaviour

Author: KBorm

README.md

@@ -7,9 +7,13 @@ following features:
 - store extra grading information (feedback from grader)
 - avoid regrading when finishing an attempt
 - special handling for internal grading errors
-- whenever a new response is saved (without grading) fraction is set to 'null'
-- optional adaptivenopenalty behaviour
-- adaptivenopenalty behaviour: fraction cannot be negative (minimum is 0)
+
+Copyright notice: The coderunner behaviour 
+(https://moodle.org/plugins/qbehaviour_adaptive_adapted_for_coderunner) was used a starting point.   
+
+
+
+raction cannot be negative (minimum is 0)
 
 
 Copyright notice: The coderunner behaviour 

behaviour.php

@@ -40,17 +40,25 @@ class qbehaviour_adaptiveexternalgrading extends qbehaviour_adaptive {
     public $showsubmit = true;
     public $showcompile = false;
 
+    protected $preferred = null;
+
     public function __construct(question_attempt $qa, $preferredbehaviour) {
-        parent::__construct($qa, $preferredbehaviour);
+        if ($preferredbehaviour == 'deferredcbm' || $preferredbehaviour == 'immediatecbm') {
+            throw new moodle_exception('proforma questions are not compatible with cbm behaviour');
+        }
 
+        parent::__construct($qa, $preferredbehaviour);
+        $this->preferred = $preferredbehaviour;
         if (!is_string($preferredbehaviour)) {
-            // happens if teacher calls question review
-            // => set dummy value
+            // happens if teacher calls question review => set dummy value
             $this->nopenalty = true;
 
             if (!is_null($preferredbehaviour)) {
                 if (get_class($preferredbehaviour) == "qbehaviour_adaptiveexternalgrading") {
                     $this->nopenalty = $preferredbehaviour->nopenalty;
+                    $this->preferred = $preferredbehaviour->preferred;
+                } else if (is_a($preferredbehaviour, 'question_behaviour')) {
+                    $this->preferred = $preferredbehaviour->get_name();
                 } else {
                     throw new coding_exception("preferredbehaviour is not a string, instead: " . get_class($preferredbehaviour));
                 }
@@ -73,6 +81,7 @@ public function __construct(question_attempt $qa, $preferredbehaviour) {
                     $this->nopenalty = true;
                     break;
                 case 'deferredfeedback':
+                case 'deferredcbm':
                     $this->nopenalty = true;
                     $this->showsubmit = false;
                     break;
@@ -87,7 +96,7 @@ public function __construct(question_attempt $qa, $preferredbehaviour) {
 
     // TODO??
     public function is_compatible_question(question_definition $question) {
-        return $question instanceof question_automatically_gradable;
+        return $question instanceof qtype_proforma_question;
     }
 
     private function get_result_from_grader($response, question_attempt_pending_step $pendingstep) {
@@ -107,7 +116,13 @@ private function get_result_from_grader($response, question_attempt_pending_step
     // - right answer with fraction 1
     // - new answer => unknown result
     public function process_save(question_attempt_pending_step $pendingstep) {
-        $status = parent::process_save($pendingstep);
+        if ($this->isdeferred()) {
+            $status = question_behaviour_with_save::process_save($pendingstep);
+
+        } else {
+            $status = parent::process_save($pendingstep);
+        }
+
         // + set fraction to null because we need new grading
         // + in case of a new response
         $pendingstep->set_fraction(null);
@@ -287,6 +302,7 @@ protected function adjusted_fraction($fraction, $prevtries) {
 
     // +
     public function get_state_string($showcorrectness) {
+        // Modify behaviour for try:
         $laststep = $this->qa->get_last_step();
         if ($laststep->has_behaviour_var('_try')) {
             if (is_null($laststep->get_behaviour_var('_rawfraction'))) {
@@ -295,8 +311,35 @@ public function get_state_string($showcorrectness) {
                 $state = $laststep->get_state();
                 return $state->default_string(true);
             }
+            return parent::get_state_string($showcorrectness);
         }
 
+        if ($this->isdeferred()) {
+            // Special treatment for deferred behaviour scenarios:
+            // In case of no input the state string from
+            // the deferred behaviour shall be used to be compliant with other question types.
+            $state = $this->qa->get_state();
+            if ($state == question_state::$todo) {
+                return question_behaviour_with_save::get_state_string($showcorrectness);
+            }
+        }
         return parent::get_state_string($showcorrectness);
     }
+
+    /**
+     * returns true if the preferred behaviour is a deferred one so that
+     * the grader need not to be executed as soon as possible.
+     * @return bool
+     */
+    protected function isdeferred() : bool {
+        if (!isset($this->preferred)) {
+            return false;
+        }
+        switch ($this->preferred) {
+            case 'deferredfeedback':
+            case 'deferredcbm':
+                return true;
+        }
+        return false;
+    }
 }

version.php

@@ -23,12 +23,12 @@
 
 defined('MOODLE_INTERNAL') || die();
 
-$plugin->version = 2019101700;
+$plugin->version = 2024111200;
 $plugin->requires = 2016120503;
 $plugin->cron = 0;
 $plugin->component = 'qbehaviour_adaptiveexternalgrading';
 $plugin->maturity = MATURITY_STABLE;
-$plugin->release = '0.9.6';
+$plugin->release = '0.9.7';
 
 $plugin->dependencies = array();