Skip to content

Commit 2a637fc

Browse files
committed
Rename TieBreakerTaggedValue to TaggedValue
1 parent 20e7069 commit 2a637fc

File tree

2 files changed

+21
-21
lines changed

2 files changed

+21
-21
lines changed

packages/d2mini/src/operators/topKWithFractionalIndex.ts

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ export class TopKWithFractionalIndexOperator<K, V1> extends UnaryOperator<
172172
* topK data structure that supports insertions and deletions
173173
* and returns changes to the topK.
174174
*/
175-
#topK: TopK<TieBreakerTaggedValue<V1>>
175+
#topK: TopK<TaggedValue<V1>>
176176

177177
constructor(
178178
id: number,
@@ -185,17 +185,17 @@ export class TopKWithFractionalIndexOperator<K, V1> extends UnaryOperator<
185185
const limit = options.limit ?? Infinity
186186
const offset = options.offset ?? 0
187187
const compareTaggedValues = (
188-
a: TieBreakerTaggedValue<V1>,
189-
b: TieBreakerTaggedValue<V1>,
188+
a: TaggedValue<V1>,
189+
b: TaggedValue<V1>,
190190
) => {
191191
// First compare on the value
192192
const valueComparison = comparator(untagValue(a), untagValue(b))
193193
if (valueComparison !== 0) {
194194
return valueComparison
195195
}
196-
// If the values are equal, compare on the tie breaker (object identity)
197-
const tieBreakerA = getTieBreaker(a)
198-
const tieBreakerB = getTieBreaker(b)
196+
// If the values are equal, compare on the tag (object identity)
197+
const tieBreakerA = getTag(a)
198+
const tieBreakerB = getTag(b)
199199
return tieBreakerA - tieBreakerB
200200
}
201201
this.#topK = this.createTopK(offset, limit, compareTaggedValues)
@@ -205,10 +205,10 @@ export class TopKWithFractionalIndexOperator<K, V1> extends UnaryOperator<
205205
offset: number,
206206
limit: number,
207207
comparator: (
208-
a: TieBreakerTaggedValue<V1>,
209-
b: TieBreakerTaggedValue<V1>,
208+
a: TaggedValue<V1>,
209+
b: TaggedValue<V1>,
210210
) => number,
211-
): TopK<TieBreakerTaggedValue<V1>> {
211+
): TopK<TaggedValue<V1>> {
212212
return new TopKArray(offset, limit, comparator)
213213
}
214214

@@ -236,7 +236,7 @@ export class TopKWithFractionalIndexOperator<K, V1> extends UnaryOperator<
236236
this.#index.addValue(key, [value, multiplicity])
237237
const newMultiplicity = this.#index.getMultiplicity(key, value)
238238

239-
let res: TopKChanges<TieBreakerTaggedValue<V1>> = {
239+
let res: TopKChanges<TaggedValue<V1>> = {
240240
moveIn: null,
241241
moveOut: null,
242242
}
@@ -341,19 +341,19 @@ function mapValue<V, W>(
341341
return [f(getValue(value)), getIndex(value)]
342342
}
343343

344-
export type TieBreaker = number
345-
export type TieBreakerTaggedValue<V> = [V, TieBreaker]
344+
export type Tag = number
345+
export type TaggedValue<V> = [V, Tag]
346346

347-
function tagValue<V>(value: V): TieBreakerTaggedValue<V> {
347+
function tagValue<V>(value: V): TaggedValue<V> {
348348
return [value, globalObjectIdGenerator.getId(value)]
349349
}
350350

351-
function untagValue<V>(tieBreakerTaggedValue: TieBreakerTaggedValue<V>): V {
351+
function untagValue<V>(tieBreakerTaggedValue: TaggedValue<V>): V {
352352
return tieBreakerTaggedValue[0]
353353
}
354354

355-
function getTieBreaker<V>(
356-
tieBreakerTaggedValue: TieBreakerTaggedValue<V>,
357-
): TieBreaker {
355+
function getTag<V>(
356+
tieBreakerTaggedValue: TaggedValue<V>,
357+
): Tag {
358358
return tieBreakerTaggedValue[1]
359359
}

packages/d2mini/src/operators/topKWithFractionalIndexBTree.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import { generateKeyBetween } from 'fractional-indexing'
55
import {
66
getIndex,
77
getValue,
8-
TieBreakerTaggedValue,
8+
TaggedValue,
99
indexedValue,
1010
IndexedValue,
1111
TopK,
@@ -241,10 +241,10 @@ export class TopKWithFractionalIndexBTreeOperator<
241241
offset: number,
242242
limit: number,
243243
comparator: (
244-
a: TieBreakerTaggedValue<V1>,
245-
b: TieBreakerTaggedValue<V1>,
244+
a: TaggedValue<V1>,
245+
b: TaggedValue<V1>,
246246
) => number,
247-
): TopK<TieBreakerTaggedValue<V1>> {
247+
): TopK<TaggedValue<V1>> {
248248
if (!BTree) {
249249
throw new Error(
250250
'B+ tree not loaded. You need to call loadBTree() before using TopKWithFractionalIndexBTreeOperator.',

0 commit comments

Comments
 (0)