-
Notifications
You must be signed in to change notification settings - Fork 295
Description
Is your feature request related to a problem? Please describe.
First of all, thank you for all the work on this project. It's excellent.
I'm using live mode with SSE and it was (and still is somewhat) unclear to me why the SSE connection times out after 60 seconds. The documentation appears to imply that the SSE connection should live indefinitely to prevent the long-polling behavior. But it times out after 60s and reopens another SSE connection
| sse_timeout: [type: :integer], |
I'm assuming this is related to the magic done for request collapsing, but, at least to me, it sort of looks like a bug based on how the documentation is written. Especially because a keep-alive message is sent every 21s, which appears at odds with this behavior.
Describe the solution you'd like
Could someone offer an explanation of why the 60s timeout is in place? And if it could potentially allow for indefinite connection duration, perhaps we could make it configurable through env vars (i.e., ELECTRIC_SSE_TIMEOUT defined in ms, where 0 is indefinite).