Skip to content

Commit 61899e2

Browse files
authored
Remove hard-coded assumption about tmp dir location (#20)
Fixes #18
1 parent 1e97c4f commit 61899e2

File tree

6 files changed

+14
-7
lines changed

6 files changed

+14
-7
lines changed

test/phoenix/sync/application_test.exs

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,8 @@ defmodule Phoenix.Sync.ApplicationTest do
8484
end
8585

8686
test "embedded mode dev env" do
87+
tmp_dir = System.tmp_dir!()
88+
8789
config = [
8890
mode: :embedded,
8991
env: :dev,
@@ -95,9 +97,10 @@ defmodule Phoenix.Sync.ApplicationTest do
9597
validate_repo_connection_opts!(opts)
9698

9799
assert %{
98-
storage: {Electric.ShapeCache.FileStorage, [storage_dir: "/tmp/" <> storage_dir]},
100+
storage:
101+
{Electric.ShapeCache.FileStorage, [storage_dir: ^tmp_dir <> "/" <> storage_dir]},
99102
persistent_kv: %Electric.PersistentKV.Filesystem{
100-
root: "/tmp/" <> storage_dir
103+
root: ^tmp_dir <> "/" <> storage_dir
101104
}
102105
} = Map.new(opts)
103106
end

test/phoenix/sync/controller_test.exs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,10 @@ defmodule Phoenix.Sync.ControllerTest do
1717
}
1818
]
1919

20-
use Plug.Test
2120
use Support.ElectricHelpers, endpoint: __MODULE__.Endpoint
2221

22+
import Plug.Test
23+
2324
require Phoenix.ConnTest
2425

2526
defmodule Router do

test/phoenix/sync/electric_test.exs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,9 @@ defmodule Phoenix.Sync.ElectricTest do
1717
}
1818
]
1919

20-
use Plug.Test
2120
use Support.ElectricHelpers, endpoint: __MODULE__.Endpoint
2221

22+
import Plug.Test
2323
import Mox
2424

2525
require Phoenix.ConnTest

test/phoenix/sync/plug_test.exs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
defmodule Phoenix.Sync.PlugTest do
22
use ExUnit.Case, async: true
3-
use Plug.Test
3+
4+
import Plug.Test
45

56
require Phoenix.ConnTest
67

test/phoenix/sync/router_test.exs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,10 @@ defmodule Phoenix.Sync.RouterTest do
1919
}
2020
]
2121

22-
use Plug.Test
2322
use Support.ElectricHelpers, endpoint: __MODULE__.Endpoint
2423

24+
import Plug.Test
25+
2526
require Phoenix.ConnTest
2627

2728
defmodule Router do

test/phoenix/sync_test.exs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
defmodule Phoenix.SyncTest do
22
use ExUnit.Case, async: true
3-
use Plug.Test
3+
4+
import Plug.Test
45

56
doctest Phoenix.Sync
67

0 commit comments

Comments
 (0)