remove password obfuscation

now handled by electric automatically

replaces #23

Author: magnetised

config/runtime.exs

@@ -5,11 +5,9 @@ if config_env() == :test do
   default_database_url = "postgresql://postgres:password@localhost:54321/electric?sslmode=disable"
   database_url = System.get_env("DATABASE_URL", default_database_url)
 
-  connection_opts = Electric.Config.parse_postgresql_uri!(database_url)
-
   config :electric,
     start_in_library_mode: true,
-    connection_opts: Electric.Utils.obfuscate_password(connection_opts),
+    connection_opts: Electric.Config.parse_postgresql_uri!(database_url),
     # enable the http api so that the client tests against a real endpoint can
     # run against our embedded electric instance.
     # enable_http_api: true,

lib/phoenix/sync/electric.ex

@@ -318,9 +318,7 @@ defmodule Phoenix.Sync.Electric do
 
   if @electric_available? do
     defp start_embedded(env, mode, db_config_fun, message) do
-      db_config =
-        db_config_fun.()
-        |> obfuscate_credentials()
+      db_config = db_config_fun.()
 
       electric_config = core_configuration(env, db_config)
 
@@ -367,24 +365,6 @@ defmodule Phoenix.Sync.Electric do
           opts
       end
     end
-
-    defp obfuscate_credentials(opts) do
-      opts
-      |> Keyword.update!(:replication_connection_opts, &Electric.Utils.obfuscate_password/1)
-      |> then(fn opts ->
-        case Keyword.fetch(opts, :query_connection_opts) do
-          :error ->
-            opts
-
-          {:ok, query_connection_opts} ->
-            Keyword.put(
-              opts,
-              :query_connection_opts,
-              Electric.Utils.obfuscate_password(query_connection_opts)
-            )
-        end
-      end)
-    end
   else
     defp start_embedded(_env, _mode, _db_config_fun, _message) do
       {:error,

test/phoenix/sync/application_test.exs

@@ -10,11 +10,9 @@ defmodule Phoenix.Sync.ApplicationTest do
           get_in(opts, [:replication_opts, :connection_opts]) || [],
           opts[:connection_opts]
         ] do
-      assert {pass_fun, connection_opts} =
+      assert {"password", connection_opts} =
                Keyword.pop!(connection_opts, :password)
 
-      assert pass_fun.() == "password"
-
       base_opts = [
         username: "postgres",
         hostname: "localhost",
@@ -213,22 +211,18 @@ defmodule Phoenix.Sync.ApplicationTest do
 
       assert {:ok, [{Electric.StackSupervisor, opts}]} = App.children(config)
 
-      assert {pass_fun, connection_opts} =
+      assert {"password", connection_opts} =
                Keyword.pop!(opts[:replication_opts][:connection_opts], :password)
 
-      assert pass_fun.() == "password"
-
       assert connection_opts == [
                username: "postgres",
                hostname: "localhost",
                database: "electric"
              ]
 
-      assert {pass_fun, connection_opts} =
+      assert {"password", connection_opts} =
                Keyword.pop!(opts[:connection_opts], :password)
 
-      assert pass_fun.() == "password"
-
       assert connection_opts == [
                username: "postgres",
                hostname: "localhost-pooled",
@@ -258,8 +252,7 @@ defmodule Phoenix.Sync.ApplicationTest do
 
       assert {:ok, [{Electric.StackSupervisor, opts}]} = App.children(config)
 
-      assert {pass_fun, connection_opts} = Keyword.pop!(opts[:connection_opts], :password)
-      assert pass_fun.() == "password"
+      assert {"password", connection_opts} = Keyword.pop!(opts[:connection_opts], :password)
 
       assert connection_opts == [
                username: "postgres",