Skip to content

Commit 48752c5

Browse files
authored
Merge pull request #114 from deepueg/add-ada
Add ada
2 parents aa1302b + 0a85be2 commit 48752c5

File tree

2 files changed

+18
-3
lines changed

2 files changed

+18
-3
lines changed

android/lib/src/main/java/com/ern/api/impl/navigation/ElectrodeNavigationFragmentDelegate.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
import android.graphics.drawable.Drawable;
44
import android.os.Bundle;
5+
import android.text.TextUtils;
56
import android.view.Menu;
67
import android.view.MenuInflater;
78
import android.view.MenuItem;
@@ -384,7 +385,11 @@ private void updateNavBar(@NonNull NavigationBar navigationBar) {
384385

385386
actionBar.setTitle(navigationBar.getTitle());
386387

387-
updateHomeAsUpIndicator(navigationBar.getLeftButton(), actionBar);
388+
NavigationBarLeftButton leftButton = navigationBar.getLeftButton();
389+
updateHomeAsUpIndicator(leftButton, actionBar);
390+
if (leftButton != null && !TextUtils.isEmpty(leftButton.getAdaLabel())) {
391+
actionBar.setHomeActionContentDescription(leftButton.getAdaLabel());
392+
}
388393

389394
if (mMenu != null && mFragment.getActivity() != null) {
390395
MenuUtil.updateMenuItems(mMenu, navigationBar, mNavBarButtonClickListener, mMenuItemDataProvider, mFragment.getActivity());

android/lib/src/main/java/com/ern/api/impl/navigation/MenuUtil.java

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,9 @@
2121
import android.graphics.BitmapFactory;
2222
import android.graphics.drawable.BitmapDrawable;
2323
import android.graphics.drawable.Drawable;
24+
import android.os.Build;
2425
import android.os.StrictMode;
25-
import android.util.Patterns;
26+
import android.text.TextUtils;
2627
import android.view.Menu;
2728
import android.view.MenuItem;
2829
import android.webkit.URLUtil;
@@ -31,6 +32,7 @@
3132
import androidx.annotation.IdRes;
3233
import androidx.annotation.NonNull;
3334
import androidx.annotation.Nullable;
35+
import androidx.core.view.MenuItemCompat;
3436

3537
import com.ernnavigationApi.ern.model.NavigationBar;
3638
import com.ernnavigationApi.ern.model.NavigationBarButton;
@@ -79,7 +81,7 @@ private static MenuItem addButtonAsMenuItem(@NonNull NavigationBarButton button,
7981
}
8082
}
8183

82-
MenuItem menuItem = menu.add(Menu.NONE, itemId, Menu.NONE, button.getTitle() != null ? button.getTitle() : button.getId());
84+
MenuItem menuItem = menu.add(Menu.NONE, itemId, Menu.NONE, button.getTitle());
8385

8486
if (icon != Menu.NONE) {
8587
Logger.d(TAG, "setting native provided menu icon, ignoring icon passed inside NavigationBarButton");
@@ -113,6 +115,14 @@ private static MenuItem addButtonAsMenuItem(@NonNull NavigationBarButton button,
113115
registerItemClickListener(menuItem, button, navBarButtonClickListener);
114116
}
115117

118+
if (!TextUtils.isEmpty(button.getAdaLabel())) {
119+
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) {
120+
menuItem.setContentDescription(button.getAdaLabel());
121+
} else {
122+
MenuItemCompat.setContentDescription(menuItem, button.getAdaLabel());
123+
}
124+
}
125+
116126
return menuItem;
117127
}
118128

0 commit comments

Comments
 (0)