Skip to content

Commit 0c96b7e

Browse files
r0h0gg6r0h0gg6
committed
Update maven publishing
1 parent e30475d commit 0c96b7e

File tree

8 files changed

+144
-37
lines changed

8 files changed

+144
-37
lines changed

‎.github/workflows/release-aar.yaml‎

Lines changed: 63 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,63 @@
1+
name: Release React Native AAR
2+
# This workflow is manually triggered to release a new React Native AAR version
3+
on:
4+
workflow_dispatch:
5+
6+
jobs:
7+
release-aar:
8+
runs-on: ubuntu-latest
9+
steps:
10+
- uses: actions/checkout@v2
11+
12+
- name: Debug NDK Configuration
13+
run: |
14+
echo "ANDROID_HOME: $ANDROID_HOME"
15+
ls -la $ANDROID_HOME/ndk/
16+
echo "Current NDK_HOME: $ANDROID_NDK_HOME"
17+
18+
- name: Clear any pre-existing local.properties
19+
run: |
20+
rm -f local.properties
21+
rm -f packages/react-native/ReactAndroid/local.properties
22+
rm -f android/local.properties
23+
24+
- name: Configure environment for correct NDK
25+
run: |
26+
# Extract NDK version
27+
NDK_VERSION=$(grep 'ndkVersion =' packages/react-native/gradle/libs.versions.toml | sed -E 's/.*"([0-9.]+)".*/\1/')
28+
echo "Using NDK version from libs.versions.toml: $NDK_VERSION"
29+
30+
# Install the correct NDK version
31+
echo "y" | $ANDROID_HOME/cmdline-tools/latest/bin/sdkmanager --install "ndk;$NDK_VERSION"
32+
33+
# Create symlink to make the installed NDK the default
34+
sudo rm -rf $ANDROID_HOME/ndk/27.2.12479018
35+
sudo ln -sf $ANDROID_HOME/ndk/$NDK_VERSION $ANDROID_HOME/ndk/27.2.12479018
36+
37+
# Verify symlink
38+
ls -la $ANDROID_HOME/ndk/
39+
readlink -f $ANDROID_HOME/ndk/27.2.12479018
40+
41+
- name: Publish Maven Artifact
42+
run: |
43+
cat <(echo -e "${{ secrets.OSSRH_GPG_SECRET_KEY }}") | gpg --batch --import
44+
gpg --list-secret-keys --keyid-format LONG
45+
yarn install
46+
echo "signing.gnupg.keyName=${OSSRH_GPG_SECRET_KEY_ID}" >> gradle.properties
47+
echo "signing.gnupg.passphrase=${OSSRH_GPG_SECRET_KEY_PASSWORD}" >> gradle.properties
48+
echo "repositoryUsername=${CENTRAL_SONATYPE_USERNAME}" >> gradle.properties
49+
echo "repositoryPassword=${CENTRAL_SONATYPE_PASSWORD}" >> gradle.properties
50+
echo "signingKey=${OSSRH_GPG_SECRET_KEY}" >> gradle.properties
51+
echo "signingPassword=${OSSRH_GPG_SECRET_KEY_PASSWORD}" >> gradle.properties
52+
sed -i.bu 's/\(react.internal.publishingGroup=\)com.facebook.react/\1com.walmartlabs.ern/g' packages/react-native/ReactAndroid/gradle.properties
53+
sed -i.bu 's/GROUP=com.facebook.react/GROUP=com.walmartlabs.ern/g' packages/react-native/ReactAndroid/hermes-engine/gradle.properties
54+
sed -i.bu 's/group = "com.facebook.react"/group = "com.walmartlabs.ern"/g' packages/react-native/ReactAndroid/hermes-engine/build.gradle.kts
55+
# Use the ndkVersion property explicitly
56+
./gradlew assembleRelease -PndkVersion=27.1.12297006
57+
./gradlew publishToSonatype closeAndReleaseSonatypeStagingRepository --stacktrace -PndkVersion=27.1.12297006
58+
env:
59+
OSSRH_GPG_SECRET_KEY_ID: ${{ secrets.OSSRH_GPG_SECRET_KEY_ID }}
60+
OSSRH_GPG_SECRET_KEY: ${{ secrets.OSSRH_GPG_SECRET_KEY }}
61+
OSSRH_GPG_SECRET_KEY_PASSWORD: ${{ secrets.OSSRH_GPG_SECRET_KEY_PASSWORD }}
62+
CENTRAL_SONATYPE_USERNAME: ${{ secrets.CENTRAL_SONATYPE_USERNAME }}
63+
CENTRAL_SONATYPE_PASSWORD: ${{ secrets.CENTRAL_SONATYPE_PASSWORD }}

‎build.gradle.kts‎

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,12 +42,12 @@ version =
4242
reactAndroidProperties.getProperty("VERSION_NAME")
4343
}
4444

45-
group = "com.facebook.react"
45+
group = "com.walmartlabs.ern"
4646

4747
val ndkPath by extra(System.getenv("ANDROID_NDK"))
4848
val ndkVersion by extra(System.getenv("ANDROID_NDK_VERSION") ?: libs.versions.ndkVersion.get())
49-
val sonatypeUsername = findProperty("SONATYPE_USERNAME")?.toString()
50-
val sonatypePassword = findProperty("SONATYPE_PASSWORD")?.toString()
49+
val sonatypeUsername = findProperty("repositoryUsername")?.toString()
50+
val sonatypePassword = findProperty("repositoryPassword")?.toString()
5151

5252
nexusPublishing {
5353
repositories {
@@ -99,10 +99,16 @@ tasks.register("publishAllToMavenTempLocal") {
9999
":packages:react-native:ReactAndroid:hermes-engine:publishAllPublicationsToMavenTempLocalRepository")
100100
}
101101

102+
tasks.register("publishAllPublicationsToErnRepository") {
103+
description = "Publish all the artifacts to be available inside a Maven Local repository on /tmp."
104+
dependsOn(":packages:react-native:ReactAndroid:publishAllPublicationsToErnRepository")
105+
// dependsOn(
106+
// ":packages:react-native:ReactAndroid:hermes-engine:publishAllPublicationsToErnRepository")
107+
}
108+
102109
tasks.register("publishAndroidToSonatype") {
103110
description = "Publish the Android artifacts to Sonatype (Maven Central or Snapshot repository)"
104111
dependsOn(":packages:react-native:ReactAndroid:publishToSonatype")
105-
dependsOn(":packages:react-native:ReactAndroid:hermes-engine:publishToSonatype")
106112
}
107113

108114
if (project.findProperty("react.internal.useHermesNightly")?.toString()?.toBoolean() == true) {

‎packages/react-native/ReactAndroid/build.gradle.kts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ plugins {
2323

2424
version = project.findProperty("VERSION_NAME")?.toString()!!
2525

26-
group = "com.facebook.react"
26+
group = "com.walmartlabs.ern"
2727

2828
// We download various C++ open-source dependencies into downloads.
2929
// We then copy both the downloaded code and our custom makefiles and headers into third-party-ndk.

‎packages/react-native/ReactAndroid/external-artifacts/build.gradle.kts‎

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -53,16 +53,16 @@ val hermesDSYMReleaseArtifact: PublishArtifact =
5353
classifier = "hermes-framework-dSYM-release"
5454
}
5555

56-
apply(from = "../publish.gradle")
56+
// apply(from = "../publish.gradle")
5757

58-
publishing {
59-
publications {
60-
getByName("release", MavenPublication::class) {
61-
artifactId = "react-native-artifacts"
62-
artifact(hermesiOSDebugArtifact)
63-
artifact(hermesiOSReleaseArtifact)
64-
artifact(hermesDSYMDebugArtifact)
65-
artifact(hermesDSYMReleaseArtifact)
66-
}
67-
}
68-
}
58+
// publishing {
59+
// publications {
60+
// getByName("release", MavenPublication::class) {
61+
// artifactId = "react-native-artifacts"
62+
// artifact(hermesiOSDebugArtifact)
63+
// artifact(hermesiOSReleaseArtifact)
64+
// artifact(hermesDSYMDebugArtifact)
65+
// artifact(hermesDSYMReleaseArtifact)
66+
// }
67+
// }
68+
// }

‎packages/react-native/ReactAndroid/gradle.properties‎

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,28 @@
11
VERSION_NAME=0.77.2
22
react.internal.publishingGroup=com.facebook.react
33

4+
# Electrode Native Sonatype Publish
5+
POM_URL=https://github.com/facebook/react-native
6+
POM_SCM_URL=https://github.com/facebook/react-native.git
7+
POM_SCM_CONNECTION=scm:git:https://github.com/facebook/react-native.git
8+
POM_SCM_DEV_CONNECTION=scm:git:[email protected]:facebook/react-native.git
9+
POM_DESCRIPTION=A framework for building native apps with React
10+
11+
POM_LICENCE_NAME=MIT License
12+
POM_LICENCE_URL=https://github.com/facebook/react-native/blob/master/LICENSE
13+
POM_LICENCE_DIST=repo
14+
15+
POM_DEVELOPER_ID=facebook
16+
POM_DEVELOPER_NAME=Facebook
17+
POM_DEVELOPER_EMAIL=[email protected]
18+
19+
SONATYPE_HOST=DEFAULT
20+
RELEASE_SIGNING_ENABLED=true
21+
22+
REPOSITORY_URL_MAVEN_STAGING_DEFAULT=https://ossrh-staging-api.central.sonatype.com/service/local/staging/deploy/maven2/
23+
REPOSITORY_URL_MAVEN_SNAPSHOT_DEFAULT=https://central.sonatype.com/repository/maven-snapshots/
24+
25+
426
android.useAndroidX=true
527

628
# We want to have more fine grained control on the Java version for

‎packages/react-native/ReactAndroid/hermes-engine/build.gradle.kts‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -301,12 +301,12 @@ android {
301301
jniLibs.excludes.add("**/libfbjni.so")
302302
}
303303

304-
publishing {
305-
multipleVariants {
306-
withSourcesJar()
307-
allVariants()
308-
}
309-
}
304+
// publishing {
305+
// multipleVariants {
306+
// withSourcesJar()
307+
// allVariants()
308+
// }
309+
// }
310310

311311
prefab {
312312
create("libhermes") {
@@ -333,12 +333,12 @@ tasks.withType<JavaCompile>().configureEach {
333333
}
334334

335335
/* Publishing Configuration */
336-
apply(from = "../publish.gradle")
336+
// apply(from = "../publish.gradle")
337337

338338
// We need to override the artifact ID as this project is called `hermes-engine` but
339339
// the maven coordinates are on `hermes-android`.
340340
// Please note that the original coordinates, `hermes-engine`, have been voided
341341
// as they caused https://github.com/facebook/react-native/issues/35210
342-
publishing {
343-
publications { getByName("release", MavenPublication::class) { artifactId = "hermes-android" } }
344-
}
342+
// publishing {
343+
// publications { getByName("release", MavenPublication::class) { artifactId = "hermes-android" } }
344+
// }

‎packages/react-native/ReactAndroid/hermes-engine/gradle.properties‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,2 @@
1+
GROUP=com.facebook.react
12
android.disableAutomaticComponentCreation=true

‎packages/react-native/ReactAndroid/publish.gradle‎

Lines changed: 25 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,23 @@ apply plugin: 'maven-publish'
99
apply plugin: 'signing'
1010

1111
def isSnapshot = findProperty("isSnapshot")?.toBoolean()
12-
def signingKey = findProperty("SIGNING_KEY")
13-
def signingPwd = findProperty("SIGNING_PWD")
12+
def signingKey = findProperty("signingKey")
13+
def signingPwd = findProperty("signingPassword")
1414

1515
def reactAndroidProjectDir = project(':packages:react-native:ReactAndroid').projectDir
1616
def mavenTempLocalUrl = "file:///tmp/maven-local"
1717

18+
19+
// ERN Publish to Maven Creds
20+
def sonatypeUsername = findProperty("repositoryUsername")
21+
def sonatypePassword = findProperty("repositoryPassword")
22+
def ernMavenCentral = "https://ossrh-staging-api.central.sonatype.com/service/local/staging/deploy/maven2/"
23+
24+
def isReleaseBuild() {
25+
return VERSION_NAME.contains("SNAPSHOT") == false
26+
}
27+
28+
1829
publishing {
1930
publications {
2031
release(MavenPublication) {
@@ -68,15 +79,19 @@ publishing {
6879
name = "mavenTempLocal"
6980
url = mavenTempLocalUrl
7081
}
82+
maven {
83+
name = "ern"
84+
url = ernMavenCentral
85+
credentials {
86+
username = sonatypeUsername
87+
password = sonatypePassword
88+
}
89+
}
7190
}
7291

73-
if (signingKey && signingPwd) {
74-
logger.info("PGP Key found - Signing enabled")
75-
signing {
76-
useInMemoryPgpKeys(signingKey, signingPwd)
77-
sign(publishing.publications.release)
78-
}
79-
} else {
80-
logger.info("Signing disabled as the PGP key was not found")
92+
signing {
93+
required { isReleaseBuild() }
94+
useGpgCmd()
95+
sign(publishing.publications.release)
8196
}
8297
}

0 commit comments

Comments
 (0)