Skip to content

Add ContextMenuBuilder argument for searching using DuckDuckGo instead of Google #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add ContextMenuBuilder argument for searching using DuckDuckGo instead of Google #138

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d5b95e
Add searchEngine context menu argument
Powersource Mar 31, 2019
bac0464
Implement searching using ddg option
Powersource Mar 31, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions src/context-menu-builder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ const contextMenuStringTable = {
addToDictionary: () => `Add to Dictionary`,
lookUpDefinition: ({word}) => `Look Up "${word}"`,
searchGoogle: () => `Search with Google`,
searchDdg: () => `Search with DuckDuckGo`,
cut: () => `Cut`,
copy: () => `Copy`,
paste: () => `Paste`,
Expand All @@ -37,11 +38,13 @@ module.exports = class ContextMenuBuilder {
* @param {Boolean} debugMode If true, display the "Inspect Element" menu item.
* @param {function} processMenu If passed, this method will be passed the menu to change
* it prior to display. Signature: (menu, info) => menu
* @param {String} searchEngine Optional. Pass either 'google' (default) or 'ddg' (for DuckDuckGo)
*/
constructor(spellCheckHandler, windowOrWebView=null, debugMode=false, processMenu=(m) => m) {
constructor(spellCheckHandler, windowOrWebView=null, debugMode=false, processMenu=null, searchEngine='google') {
this.spellCheckHandler = spellCheckHandler;
this.debugMode = debugMode;
this.processMenu = processMenu;
this.processMenu = processMenu || ((m) => m);
this.searchEngine = searchEngine;
this.menu = null;
this.stringTable = Object.assign({}, contextMenuStringTable);

Expand Down Expand Up @@ -296,7 +299,13 @@ module.exports = class ContextMenuBuilder {
menu.append(lookUpDefinition);
}

let search = new MenuItem({
let search = new MenuItem(this.searchEngine === 'ddg' ? {
label: this.stringTable.searchDdg(),
click: () => {
let url = `https://duckduckgo.com/?q=${encodeURIComponent(menuInfo.selectionText)}`;
shell.openExternal(url);
}
} : {
label: this.stringTable.searchGoogle(),
click: () => {
let url = `https://www.google.com/#q=${encodeURIComponent(menuInfo.selectionText)}`;
Expand Down