From a8a040bb62d7f472813ae8cb2a7bbb49835d644f Mon Sep 17 00:00:00 2001 From: Joshua Pawlicki Date: Mon, 13 Apr 2020 09:15:38 -0700 Subject: [PATCH 1/2] Do not dispatch a changed event if dict not changed. In the case that actualLang == currentSpellcheckerLanguage, there is no need to fire a spellchecker changed event. This is already the behavior in the happy case (see if statement on old line 411). This commit makes that consistent with the !dict error case. --- src/spell-check-handler.js | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/spell-check-handler.js b/src/spell-check-handler.js index f860dd8..ee73d98 100644 --- a/src/spell-check-handler.js +++ b/src/spell-check-handler.js @@ -401,9 +401,11 @@ module.exports = class SpellCheckHandler { if (!dict) { d(`dictionary for ${langCode}_${actualLang} is not available`); - this.currentSpellcheckerLanguage = actualLang; - this.currentSpellchecker = null; - this.currentSpellcheckerChanged.next(true); + if (this.currentSpellcheckerLanguage !== actualLang) { + this.currentSpellcheckerLanguage = actualLang; + this.currentSpellchecker = null; + this.currentSpellcheckerChanged.next(true); + } return; } From e8e321687b8a9025dadf88744df52dc3fa073279 Mon Sep 17 00:00:00 2001 From: Joshua Pawlicki Date: Mon, 13 Apr 2020 09:50:38 -0700 Subject: [PATCH 2/2] tabs to spaces --- src/spell-check-handler.js | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/spell-check-handler.js b/src/spell-check-handler.js index ee73d98..1bed788 100644 --- a/src/spell-check-handler.js +++ b/src/spell-check-handler.js @@ -401,11 +401,11 @@ module.exports = class SpellCheckHandler { if (!dict) { d(`dictionary for ${langCode}_${actualLang} is not available`); - if (this.currentSpellcheckerLanguage !== actualLang) { - this.currentSpellcheckerLanguage = actualLang; - this.currentSpellchecker = null; - this.currentSpellcheckerChanged.next(true); - } + if (this.currentSpellcheckerLanguage !== actualLang) { + this.currentSpellcheckerLanguage = actualLang; + this.currentSpellchecker = null; + this.currentSpellcheckerChanged.next(true); + } return; }