Skip to content

Commit 0b18947

Browse files
authored
ci: run tests on Ubuntu and Windows (#291)
* ci: run tests on Ubuntu and Windows * ci: set `core.autocrlf=input`
1 parent ed7b762 commit 0b18947

File tree

1 file changed

+17
-3
lines changed

1 file changed

+17
-3
lines changed

.github/workflows/test.yml

Lines changed: 17 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,25 @@ jobs:
2222
- '22.12.x'
2323
os:
2424
- macos-latest
25-
# TODO(dsanders11: Enable these once we fix tests on those platforms in CI
26-
# - ubuntu-latest
27-
# - windows-latest
25+
- ubuntu-latest
26+
- windows-latest
2827
runs-on: "${{ matrix.os }}"
2928
steps:
29+
- run: git config --global core.autocrlf input
30+
- name: Configure ubuntu
31+
if: contains(matrix.os, 'ubuntu')
32+
shell: bash
33+
run: |-
34+
# Setup a virtual display for Electron tests
35+
sudo apt install -y xvfb
36+
sudo Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 &
37+
echo "DISPLAY=:99" >> $GITHUB_ENV
38+
39+
# Workaround for Electron AppImage apps failing to initialize on Ubuntu due to AppArmor restrictions
40+
# Disables unprivileged user namespaces restriction to allow Electron apps to run
41+
# Reference: https://github.com/electron/electron/issues/42510
42+
: https://github.com/electron-userland/electron-builder/issues/8440
43+
sudo sysctl -w kernel.apparmor_restrict_unprivileged_userns=0
3044
- name: Checkout
3145
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
3246
- name: Setup Node.js

0 commit comments

Comments
 (0)