Merge pull request #26 from aryanshridhar/Add-RunnerDeafultArg

refactor: add default parameter for Runner.create

Author: ckerr

src/runner.ts

@@ -53,12 +53,14 @@ export class Runner {
     getos((err, result) => (this.osInfo = inspect(result || err)));
   }
 
-  public static async create(opts: {
-    installer?: Installer;
-    fiddleFactory?: FiddleFactory;
-    paths?: Partial<Paths>;
-    versions?: Versions;
-  }): Promise<Runner> {
+  public static async create(
+    opts: {
+      installer?: Installer;
+      fiddleFactory?: FiddleFactory;
+      paths?: Partial<Paths>;
+      versions?: Versions;
+    } = {},
+  ): Promise<Runner> {
     const paths = Object.freeze({ ...DefaultPaths, ...(opts.paths || {}) });
     const installer = opts.installer || new Installer(paths);
     const versions = opts.versions || (await ElectronVersions.create(paths));

tests/runner.test.ts

@@ -63,7 +63,7 @@ describe('Runner', () => {
 
   describe('create()', () => {
     it('creates a Runner object with the expected properties', async () => {
-      const runner = await Runner.create({});
+      const runner = await Runner.create();
       expect(Object.keys(runner)).toEqual([
         'installer',
         'versions',
@@ -171,7 +171,7 @@ describe('Runner', () => {
     ])(
       'can handle a test with the `%s` status',
       async (status, event, exitCode) => {
-        const runner = await Runner.create({});
+        const runner = await Runner.create();
         const fakeSubprocess = new EventEmitter();
         runner.spawn = jest.fn().mockResolvedValue(fakeSubprocess);