chore: extract-method isCacheFresh()

Author: ckerr

src/versions.ts

@@ -183,8 +183,6 @@ export class BaseVersions implements Versions {
   }
 }
 
-const VERSION_CACHE_TTL_MS = 4 * 60 * 60 * 1000; // cache for N hours
-
 /**
  * Implementation of Versions that self-populates from release information at
  * https://releases.electronjs.org/releases.json .
@@ -210,6 +208,11 @@ export class ElectronVersions extends BaseVersions {
     return json;
   }
 
+  private static isCacheFresh(cacheTimeMs: number, now: number): boolean {
+    const VERSION_CACHE_TTL_MS = 4 * 60 * 60 * 1000; // cache for N hours
+    return now <= cacheTimeMs + VERSION_CACHE_TTL_MS;
+  }
+
   public static async create(
     paths: Partial<Paths> = {},
   ): Promise<ElectronVersions> {
@@ -220,10 +223,10 @@ export class ElectronVersions extends BaseVersions {
     const now = Date.now();
     try {
       const st = await fs.stat(versionsCache);
-      if (now <= st.mtimeMs + VERSION_CACHE_TTL_MS)
+      if (ElectronVersions.isCacheFresh(st.mtimeMs, now))
         versions = (await fs.readJson(versionsCache)) as unknown;
     } catch (err) {
-      // cache file missing
+      // cache file missing or cannot be read
     }
 
     if (!versions) {
@@ -244,7 +247,7 @@ export class ElectronVersions extends BaseVersions {
     // if it's still fresh, do nothing
     const { mtimeMs, versionsCache } = this;
     const now = Date.now();
-    if (now <= mtimeMs + VERSION_CACHE_TTL_MS) return;
+    if (ElectronVersions.isCacheFresh(mtimeMs, now)) return;
 
     // update the cache
     try {