Skip to content

Commit 9dd4bc9

Browse files
authored
chore: add process.noAsar typing as ambient declaration (#48)
1 parent 0ef9fbe commit 9dd4bc9

File tree

3 files changed

+8
-12
lines changed

3 files changed

+8
-12
lines changed

src/ambient.d.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
declare namespace NodeJS {
2+
interface Process {
3+
noAsar?: boolean;
4+
}
5+
}

src/fiddle.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -47,13 +47,10 @@ export class FiddleFactory {
4747
await fs.remove(folder);
4848

4949
// Disable asar in case any deps bundle Electron - ex. @electron/remote
50-
// @ts-ignore
5150
const { noAsar } = process;
52-
// @ts-ignore
5351
process.noAsar = true;
5452
await fs.copy(source, folder);
55-
// @ts-ignore
56-
process.noAsar = noAsar; // eslint-disable-line
53+
process.noAsar = noAsar;
5754

5855
return new Fiddle(path.join(folder, 'main.js'), source);
5956
}

src/installer.ts

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -346,26 +346,20 @@ export class Installer extends EventEmitter {
346346
if (alreadyExtracted) {
347347
await this.installVersionImpl(version, zipFile, () => {
348348
// Simply copy over the files from preinstalled version to `electronInstall`
349-
// @ts-ignore
350349
const { noAsar } = process;
351-
// @ts-ignore
352350
process.noAsar = true;
353351
fs.copySync(zipFile, electronInstall);
354-
// @ts-ignore
355-
process.noAsar = noAsar; // eslint-disable-line
352+
process.noAsar = noAsar;
356353
});
357354
} else {
358355
await this.installVersionImpl(version, zipFile, async () => {
359356
// FIXME(anyone) is there a less awful way to wrangle asar
360-
// @ts-ignore: yes, I know noAsar isn't defined in process
361357
const { noAsar } = process;
362358
try {
363-
// @ts-ignore: yes, I know noAsar isn't defined in process
364359
process.noAsar = true;
365360
await extract(zipFile, { dir: electronInstall });
366361
} finally {
367-
// @ts-ignore: yes, I know noAsar isn't defined in process
368-
process.noAsar = noAsar; // eslint-disable-line
362+
process.noAsar = noAsar;
369363
}
370364
});
371365
}

0 commit comments

Comments
 (0)