Download Progress Bar Goes Straight to 100%

[dsanders11]

When displaying download progress, it goes straight to "🏁 downloading 23.0.0-beta.3 - 100%"

Doing some logging, it looks like the progress percentages it receives are 0, 1, 0, and then actual fractional values. When 1 is received it sets progress to 100% and considers it done and doesn't display the real progress updates.

Issue is upstream either in @electron/get or got.

[marfgold1]

The issue is in got.stream. Here's the following breakdown:

1. Progress received total (as provided by the Content-Length) as undefined at first, which makes the percent comes to 0.
2. Progress received total of 0 with transferred (total downloaded size) equal to 0 too, which makes the percent to be 1.
3. Progress eventually receive the correct total, which makes the percent goes back to 0 again, then actual fractional values.

I'm not sure if that was intended in got.stream (going to investigate at this moment), but one suggestion that I can think of is changing @electron/get at GotDownloader.download such that when listening to downloadProgress of the got.stream, we should return early if !progress.total (or to be exact, equal to 0 or undefined), which ignores the first and second case.

[marfgold1]

I think I found the culprit, it's because got.stream report downloadProgress when redirect. The GitHub artifacts redirect user to the actual content when someone downloading the release artifact file.
For example, if we want to download electron-v29.1.5-win32-x64, it will hit an HTTP/1.1 302 Found and redirect us to domain objects.githubusercontent.com, the actual content, with content-length of 0. got.stream report the before redirect content-length as undefined first, then 0 when it ends the redirect, just before requesting the actual content.

This behavior also exist in another URL which needs redirects, for example http://youtube.com will redirect to https://youtube.com and finally redirect to https://www.youtube.com.

A simple fix is checking total that I propose before, but I'm not sure if we should forward it to got.

[botPuneet]

hey @dsanders11 sir, i made a pr related to this issue i think it is due to we dont consider the fraction numbers. Pls review it and i am open for any feedback. #pr