Skip to content

feat: replace simple-git with octokit to load fiddle #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: replace simple-git with octokit to load fiddle #50

wants to merge 1 commit into from
+112 −41

Conversation

aryanshridhar
Copy link
Contributor

@aryanshridhar aryanshridhar commented Oct 19, 2022 •
edited
Loading

TODOs

  • Fix all TODOs in codebase.
  • Write tests
  • Handle better way to set env variables (probably?)

Fixes #38

@aryanshridhar aryanshridhar marked this pull request as ready for review October 21, 2022 10:35
@aryanshridhar
Copy link
Contributor Author

Ready for first round of review @dsanders11 :)

@erickzhao erickzhao requested a review from a team November 3, 2022 20:43
@dsanders11 dsanders11 self-assigned this Feb 7, 2024
@marfgold1
Copy link

I think it's okay if file other than VALID_FILES is being pushed to the contents too. The original Electron Fiddle app allows any other files to be pulled from the gist by prompting if the user wants to add that file first before adding in to the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dsanders11 dsanders11

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't Load Gist
3 participants
@aryanshridhar @marfgold1 @dsanders11