Skip to content

Commit 6995022

Browse files
authored
style: add aria-labels for label-less forms (#1171)
style: add aria-labels for labelless forms
1 parent 4f785dc commit 6995022

File tree

3 files changed

+9
-1
lines changed

3 files changed

+9
-1
lines changed

src/renderer/components/commands-address-bar.tsx

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,11 @@ export const AddressBar = observer(
142142

143143
const isPerformingAction = activeGistAction !== GistActionState.none;
144144
return (
145-
<form className={className} onSubmit={this.handleSubmit}>
145+
<form
146+
className={className}
147+
aria-label={'Enter Fiddle Gist URL'}
148+
onSubmit={this.handleSubmit}
149+
>
146150
<fieldset disabled={isPerformingAction}>
147151
<InputGroup
148152
key="addressbar"

src/renderer/components/settings-execution.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -205,6 +205,7 @@ export const ExecutionSettings = observer(
205205
{varsArray.map(([idx, envVar]) => {
206206
return (
207207
<InputGroup
208+
aria-label={'Set user-provided environment variables'}
208209
placeholder='NODE_OPTIONS="--no-warnings --max-old-space-size=2048"'
209210
value={envVar}
210211
name={idx}
@@ -240,6 +241,7 @@ export const ExecutionSettings = observer(
240241
{flagsArray.map(([idx, flag]) => {
241242
return (
242243
<InputGroup
244+
aria-label={'Set user-provided flags'}
243245
placeholder="--js-flags=--expose-gc"
244246
value={flag}
245247
name={idx}

tests/renderer/components/__snapshots__/settings-execution-spec.tsx.snap

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,7 @@ exports[`ExecutionSettings component renders 1`] = `
7373
</p>
7474
<br />
7575
<Blueprint3.InputGroup
76+
aria-label="Set user-provided flags"
7677
key="0"
7778
name="0"
7879
onChange={[Function]}
@@ -115,6 +116,7 @@ exports[`ExecutionSettings component renders 1`] = `
115116
</p>
116117
<br />
117118
<Blueprint3.InputGroup
119+
aria-label="Set user-provided environment variables"
118120
key="0"
119121
name="0"
120122
onChange={[Function]}

0 commit comments

Comments
 (0)