refactor: replace got with native fetch API (#4189)

chore: remove got dependency in favor of built-in fetch

Replace the got HTTP client with native fetch in the zip maker for
fetching RELEASES.json manifests. Native fetch has been stable in
Node.js since v18 and the package already requires Node >= 22.12.0.

Also remove the unused got dependency from @electron-forge/core.

Co-authored-by: Claude <noreply@anthropic.com>

Author: MarshallOfSound

packages/maker/zip/package.json

@@ -18,8 +18,7 @@
     "@electron-forge/maker-base": "workspace:*",
     "@electron-forge/shared-types": "workspace:*",
     "cross-zip": "^4.0.0",
-    "fs-extra": "^10.0.0",
-    "got": "^14.0.0"
+    "fs-extra": "^10.0.0"
   },
   "publishConfig": {
     "access": "public"

packages/maker/zip/spec/MakerZip.spec.ts

@@ -4,8 +4,7 @@ import path from 'node:path';
 import { ForgeArch } from '@electron-forge/shared-types';
 import { zip } from 'cross-zip';
 import fs from 'fs-extra';
-import { got } from 'got';
-import { describe, expect, it, vi } from 'vitest';
+import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
 
 import { MakerZIP } from '../src/MakerZIP';
 
@@ -32,19 +31,17 @@ vi.mock(import('fs-extra'), async (importOriginal) => {
   };
 });
 
-// @ts-expect-error - This mock works but vi.mock isn't happy.
-vi.mock(import('got'), async (importOriginal) => {
-  const mod = await importOriginal();
-  return {
-    ...mod,
-    got: {
-      ...mod.got,
-      get: vi.fn(),
-    },
-  };
-});
-
 describe('MakerZip', () => {
+  const mockFetch = vi.fn();
+
+  beforeEach(() => {
+    vi.stubGlobal('fetch', mockFetch);
+  });
+
+  afterEach(() => {
+    vi.unstubAllGlobals();
+  });
+
   const dir = path.resolve(import.meta.dirname, 'fixture', 'fake-app');
   const darwinDir = path.resolve(
     import.meta.dirname,
@@ -141,7 +138,7 @@ describe('MakerZip', () => {
         });
 
         expect(output).toHaveLength(1);
-        expect(got.get).not.toHaveBeenCalled();
+        expect(mockFetch).not.toHaveBeenCalled();
       },
     );
 
@@ -155,7 +152,7 @@ describe('MakerZip', () => {
         );
         maker.prepareConfig(targetArch);
         maker.ensureFile = vi.fn();
-        vi.mocked(got.get).mockResolvedValue({ statusCode: 200, body: '{}' });
+        mockFetch.mockResolvedValue(new Response('{}', { status: 200 }));
         await maker.make({
           dir: darwinDir,
           makeDir,
@@ -166,7 +163,7 @@ describe('MakerZip', () => {
           forgeConfig: null as any,
         });
 
-        expect(got.get).toHaveBeenCalledOnce();
+        expect(mockFetch).toHaveBeenCalledOnce();
         expect(fs.writeJson).toHaveBeenCalledWith(expect.anything(), {
           currentRelease: '1.2.3',
           releases: [
@@ -193,10 +190,7 @@ describe('MakerZip', () => {
         );
         maker.prepareConfig(targetArch);
         maker.ensureFile = vi.fn();
-        vi.mocked(got.get).mockResolvedValue({
-          statusCode: 404,
-          body: undefined,
-        });
+        mockFetch.mockResolvedValue(new Response(null, { status: 404 }));
         await maker.make({
           dir: darwinDir,
           makeDir,
@@ -207,7 +201,7 @@ describe('MakerZip', () => {
           forgeConfig: null as any,
         });
 
-        expect(got.get).toHaveBeenCalledOnce();
+        expect(mockFetch).toHaveBeenCalledOnce();
         expect(fs.writeJson).toHaveBeenCalledWith(expect.anything(), {
           currentRelease: '1.2.3',
           releases: [
@@ -243,13 +237,15 @@ describe('MakerZip', () => {
             url: 'fake://test/bar',
           },
         };
-        vi.mocked(got.get).mockResolvedValue({
-          statusCode: 200,
-          body: JSON.stringify({
-            currentRelease: '1.1.1',
-            releases: [oneOneOneRelease],
-          }),
-        });
+        mockFetch.mockResolvedValue(
+          new Response(
+            JSON.stringify({
+              currentRelease: '1.1.1',
+              releases: [oneOneOneRelease],
+            }),
+            { status: 200 },
+          ),
+        );
         await maker.make({
           dir: darwinDir,
           makeDir,

packages/maker/zip/src/MakerZIP.ts

@@ -5,7 +5,6 @@ import { MakerBase, MakerOptions } from '@electron-forge/maker-base';
 import { ForgePlatform } from '@electron-forge/shared-types';
 import { zip } from 'cross-zip';
 import fs from 'fs-extra';
-import { got } from 'got';
 
 import { MakerZIPConfig } from './Config.js';
 
@@ -62,15 +61,13 @@ export default class MakerZIP extends MakerBase<MakerZIPConfig> {
     if (targetPlatform === 'darwin' && this.config.macUpdateManifestBaseUrl) {
       const parsed = new URL(this.config.macUpdateManifestBaseUrl);
       parsed.pathname += '/RELEASES.json';
-      const response = await got.get(parsed.toString(), {
-        throwHttpErrors: false,
-      });
+      const response = await fetch(parsed.toString());
       let currentValue: SquirrelMacReleases = {
         currentRelease: '',
         releases: [],
       };
-      if (response.statusCode === 200) {
-        currentValue = JSON.parse(response.body);
+      if (response.status === 200) {
+        currentValue = (await response.json()) as SquirrelMacReleases;
       }
       const updateUrl = new URL(this.config.macUpdateManifestBaseUrl);
       updateUrl.pathname += `/${zipName}`;

yarn.lock

@@ -1043,7 +1043,6 @@ __metadata:
     "@electron-forge/shared-types": "workspace:*"
     cross-zip: "npm:^4.0.0"
     fs-extra: "npm:^10.0.0"
-    got: "npm:^14.0.0"
     vitest: "npm:^4.0.14"
   languageName: unknown
   linkType: soft