Skip to content

Commit 8389bca

Browse files
authored
ci: use .nvmrc file for CI (#4081)
1 parent 087d40c commit 8389bca

File tree

1 file changed

+12
-18
lines changed

1 file changed

+12
-18
lines changed

.github/workflows/ci.yml

Lines changed: 12 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -11,31 +11,27 @@ on:
1111
types: [checks_requested]
1212
workflow_call:
1313

14-
env:
15-
NODE_VERSION: 20.17.0
16-
1714
jobs:
1815
lint-and-build:
1916
runs-on: ubuntu-22.04
2017
steps:
2118
- name: Configure git
2219
run: git config --global core.autocrlf input
2320

21+
- name: Checkout code
22+
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
23+
2424
- name: Setup Node.js
2525
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
2626
with:
27-
node-version: ${{ env.NODE_VERSION }}
28-
# cache: yarn
27+
node-version-file: .nvmrc
2928

3029
# TODO(Forge 8): remove this once we can upgrade to `@electron/rebuild` v4
3130
- name: Set up Python 3.11 (with distutils)
3231
uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5.6.0
3332
with:
3433
python-version: 3.11
3534

36-
- name: Checkout code
37-
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
38-
3935
- name: Install dependencies
4036
run: yarn install --immutable
4137

@@ -80,21 +76,20 @@ jobs:
8076
- name: Configure git
8177
run: git config --global core.autocrlf input
8278

79+
- name: Checkout code
80+
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
81+
8382
- name: Setup Node.js
8483
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
8584
with:
86-
node-version: ${{ env.NODE_VERSION }}
87-
# cache: yarn
85+
node-version-file: .nvmrc
8886

8987
# TODO(Forge 8): remove this once we can upgrade to `@electron/rebuild` v4
9088
- name: Set up Python 3.11 (with distutils)
9189
uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5.6.0
9290
with:
9391
python-version: 3.11
9492

95-
- name: Checkout code
96-
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
97-
9893
- name: Install dependencies
9994
run: yarn install --immutable
10095

@@ -156,21 +151,20 @@ jobs:
156151
- name: Configure git
157152
run: git config --global core.autocrlf input
158153

154+
- name: Checkout code
155+
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
156+
159157
- name: Setup Node.js
160158
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
161159
with:
162-
node-version: ${{ env.NODE_VERSION }}
163-
# cache: yarn
160+
node-version-file: .nvmrc
164161

165162
# TODO(Forge 8): remove this once we can upgrade to `@electron/rebuild` v4
166163
- name: Set up Python 3.11 (with distutils)
167164
uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5.6.0
168165
with:
169166
python-version: 3.11
170167

171-
- name: Checkout code
172-
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
173-
174168
- name: Install dependencies
175169
run: yarn install --immutable
176170

0 commit comments

Comments
 (0)