Skip to content

Commit ecfad78

Browse files
authored
Merge branch 'main' into dependabot/github_actions/amannn/action-semantic-pull-request-6.1.1
2 parents 467553c + e627f07 commit ecfad78

File tree

5 files changed

+12
-22
lines changed

5 files changed

+12
-22
lines changed

.github/workflows/gh-pages.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ jobs:
1818
with:
1919
creds: ${{ secrets.GH_APP_CREDS }}
2020

21-
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
21+
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
2222
with:
2323
submodules: true
2424
fetch-depth: 0

.github/workflows/stale.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ jobs:
1313
issues: write
1414
pull-requests: write
1515
steps:
16-
- uses: actions/stale@5bef64f19d7facfb25b37b414482c7164d639639 # v9.1.0
16+
- uses: actions/stale@3a9db7e6a41a89f618792c92c0e97cc736e1b13f # v10.0.0
1717
with:
1818
repo-token: ${{ secrets.GITHUB_TOKEN }}
1919
any-of-labels: 'blocked/needs-info,blocked/needs-repro'

README.md

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -30,15 +30,11 @@ Pre-requisites:
3030
- Node 16.4.0 or higher
3131
- Git
3232

33-
If you have a more recent version of `npm` or `yarn`, you can use
34-
[`npx`](https://medium.com/@maybekatz/introducing-npx-an-npm-package-runner-55f7d4bd282b),
35-
or
36-
[`yarn create`](https://yarnpkg.com/blog/2017/05/12/introducing-yarn/).
33+
You can initialize an Electron Forge project with the [`create-electron-app`](https://www.npmjs.com/package/create-electron-app)
34+
CLI tool.
3735

3836
```bash
39-
npx create-electron-app my-new-app
40-
# or
41-
yarn create electron-app my-new-app
37+
npx create-electron-app@latest my-new-app
4238

4339
# then
4440
cd my-new-app

packages/api/cli/src/electron-forge-init.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import fs from 'node:fs/promises';
1+
import fs from 'node:fs';
22

33
import { api, InitOptions } from '@electron-forge/core';
44
import { confirm, select } from '@inquirer/prompts';
@@ -58,7 +58,8 @@ program
5858

5959
if (
6060
typeof initOpts.dir === 'string' &&
61-
(await fs.readdir(initOpts.dir)).length > 0
61+
fs.existsSync(initOpts.dir) &&
62+
(await fs.promises.readdir(initOpts.dir)).length > 0
6263
) {
6364
const confirmResult = await prompt.run(confirm, {
6465
message: `${chalk.cyan(initOpts.dir)} is not empty. Would you like to continue and overwrite existing files?`,
Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,27 +1,20 @@
11
## create-electron-app
22

3-
Create Electron App allows you to quickly bootstrap a new Electron app, using Electron Forge.
3+
Create Electron App allows you to quickly bootstrap a new Electron app using
4+
[Electron Forge](https://electronforge.io).
45

56
### Usage
67

78
Initialize a new project by running the following:
89

910
```sh
10-
# yarn 1
11-
yarn create electron-app my-app
12-
13-
# npm
1411
npx create-electron-app@latest my-app
1512
```
1613

17-
You should now have a directory called my-app with an ultra-minimal Electron app boilerplate inside. If you head into that directory and start up the app, you'll be all set to start developing!
14+
You should now have a directory called my-app with an ultra-minimal Electron app boilerplate inside.
15+
If you head into that directory and start up the app, you'll be all set to start developing!
1816

1917
```sh
20-
# yarn 1
21-
cd my-app
22-
yarn start
23-
24-
# npm
2518
cd my-app
2619
npm start
2720
```

0 commit comments

Comments
 (0)