Skip to content

Commit 3057b15

Browse files
committed
use graceful-fs instead of node:fs
1 parent 0d1dd55 commit 3057b15

File tree

3 files changed

+26
-4
lines changed

3 files changed

+26
-4
lines changed

package.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@
3535
"devDependencies": {
3636
"@tsconfig/node22": "^22.0.0",
3737
"@types/debug": "^4.1.12",
38+
"@types/graceful-fs": "^4.1.9",
3839
"@types/node": "~22.10.7",
3940
"@types/promise-retry": "^1.1.3",
4041
"prettier": "^3.4.2",
@@ -45,6 +46,7 @@
4546
},
4647
"dependencies": {
4748
"debug": "^4.4.0",
49+
"graceful-fs": "^4.2.11",
4850
"promise-retry": "^2.0.1"
4951
}
5052
}

src/helpers.ts

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,25 @@
11
import debug from 'debug';
2+
import * as fs from 'graceful-fs';
23

3-
import * as fs from 'node:fs/promises';
44
import * as os from 'node:os';
55
import * as path from 'node:path';
6+
import * as util from 'node:util';
67

78
const d = debug('electron-notarize:helpers');
89

910
export async function withTempDir<T>(fn: (dir: string) => Promise<T>) {
10-
const dir = await fs.mkdtemp(path.resolve(os.tmpdir(), 'electron-notarize-'));
11+
const dir = await util.promisify(fs.mkdtemp)(path.resolve(os.tmpdir(), 'electron-notarize-'));
1112
d('doing work inside temp dir:', dir);
1213
let result: T;
1314
try {
1415
result = await fn(dir);
1516
} catch (err) {
1617
d('work failed');
17-
await fs.rm(dir, { recursive: true, force: true });
18+
await util.promisify(fs.rm)(dir, { recursive: true, force: true });
1819
throw err;
1920
}
2021
d('work succeeded');
21-
await fs.rm(dir, { recursive: true, force: true });
22+
await util.promisify(fs.rm)(dir, { recursive: true, force: true });
2223
return result;
2324
}
2425

yarn.lock

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -244,11 +244,25 @@
244244
resolved "https://registry.yarnpkg.com/@types/estree/-/estree-1.0.6.tgz#628effeeae2064a1b4e79f78e81d87b7e5fc7b50"
245245
integrity sha512-AYnb1nQyY49te+VRAVgmzfcgjYS91mY5P0TKUDCLEM+gNnA+3T6rWITXRLYCpahpqSQbN5cE+gHpnPyXjHWxcw==
246246

247+
"@types/graceful-fs@^4.1.9":
248+
version "4.1.9"
249+
resolved "https://registry.yarnpkg.com/@types/graceful-fs/-/graceful-fs-4.1.9.tgz#2a06bc0f68a20ab37b3e36aa238be6abdf49e8b4"
250+
integrity sha512-olP3sd1qOEe5dXTSaFvQG+02VdRXcdytWLAZsAq1PecU8uqQAhkrnbli7DagjtXKW/Bl7YJbUsa8MPcuc8LHEQ==
251+
dependencies:
252+
"@types/node" "*"
253+
247254
"@types/ms@*":
248255
version "2.1.0"
249256
resolved "https://registry.yarnpkg.com/@types/ms/-/ms-2.1.0.tgz#052aa67a48eccc4309d7f0191b7e41434b90bb78"
250257
integrity sha512-GsCCIZDE/p3i96vtEqx+7dBUGXrc7zeSK3wwPHIaRThS+9OhWIXRqzs4d6k1SVU8g91DrNRWxWUGhp5KXQb2VA==
251258

259+
"@types/node@*":
260+
version "22.13.10"
261+
resolved "https://registry.yarnpkg.com/@types/node/-/node-22.13.10.tgz#df9ea358c5ed991266becc3109dc2dc9125d77e4"
262+
integrity sha512-I6LPUvlRH+O6VRUqYOcMudhaIdUVWfsjnZavnsraHvpBwaEyMN29ry+0UVJhImYL16xsscu0aske3yA+uPOWfw==
263+
dependencies:
264+
undici-types "~6.20.0"
265+
252266
"@types/node@~22.10.7":
253267
version "22.10.7"
254268
resolved "https://registry.yarnpkg.com/@types/node/-/node-22.10.7.tgz#14a1ca33fd0ebdd9d63593ed8d3fbc882a6d28d7"
@@ -440,6 +454,11 @@ fsevents@~2.3.2, fsevents@~2.3.3:
440454
resolved "https://registry.yarnpkg.com/fsevents/-/fsevents-2.3.3.tgz#cac6407785d03675a2a5e1a5305c697b347d90d6"
441455
integrity sha512-5xoDfX+fL7faATnagmWPpbFtwh/R77WmMMqqHGS65C3vvB0YHrgF+B1YmZ3441tMj5n63k0212XNoJwzlhffQw==
442456

457+
graceful-fs@^4.2.11:
458+
version "4.2.11"
459+
resolved "https://registry.yarnpkg.com/graceful-fs/-/graceful-fs-4.2.11.tgz#4183e4e8bf08bb6e05bbb2f7d2e0c8f712ca40e3"
460+
integrity sha512-RbJ5/jmFcNNCcDV5o9eTnBLJ/HszWV0P73bc+Ff4nS/rJj+YaS6IGyiOL0VoBYX+l1Wrl3k63h/KrH+nhJ0XvQ==
461+
443462
jsonc-parser@^3.2.0:
444463
version "3.2.1"
445464
resolved "https://registry.yarnpkg.com/jsonc-parser/-/jsonc-parser-3.2.1.tgz#031904571ccf929d7670ee8c547545081cb37f1a"

0 commit comments

Comments
 (0)