Skip to content

Commit 1872d1c

Browse files
authored
fix: handle new EventEmitter type in node@13 type defs
* fix: compilation error with the latest @types/node this patch will fix electron/electron#21612 * apply suggestions by @MarshallOfSound
1 parent d2229f7 commit 1872d1c

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

base/base_inner.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
const NodeEventEmitter: typeof import('events').EventEmitter;
2+
13
class Accelerator extends String {
24

35
}

src/module-declaration.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,11 @@ export const generateModuleDeclaration = (
4444
`${isClass ? 'class' : 'interface'} ${_.upperFirst(
4545
module.name,
4646
)} extends ${module.extends ||
47-
(module.name === 'remote' ? 'MainInterface' : 'NodeJS.EventEmitter')} {`,
47+
(module.name === 'remote'
48+
? 'MainInterface'
49+
: isClass
50+
? 'NodeEventEmitter'
51+
: 'NodeJS.EventEmitter')} {`,
4852
);
4953
moduleAPI.push('', `// Docs: ${module.websiteUrl}`, '');
5054
} else {

0 commit comments

Comments
 (0)